Commit 156588b
committed
test(redis-4): fix tests with [email protected] and earlier
In [email protected] and earlier versions of redis v4, client.disconnect()
will throw if the connect failed. That broke the "with empty string for
client URL, ..." test case, at least on macOS:
npm run test:docker:run
RUN_REDIS_TESTS=1 npm t
I cannot explain why this is not failing in CI. Perhaps something
platform specific? This is related to socket handling in the redis
client. I believe the relevant change in node-redis was:
redis/node-redis#2295
which was part of `@redis/[email protected]` which was included in
`[email protected]`.1 parent 212fc05 commit 156588b
File tree
1 file changed
+6
-1
lines changed- plugins/node/opentelemetry-instrumentation-redis-4/test
1 file changed
+6
-1
lines changedLines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
317 | | - | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
318 | 323 | | |
319 | 324 | | |
320 | 325 | | |
| |||
0 commit comments