refactor(instrumentation-fastify): update semconv usage to ATTR_ exports (#2862)

Author: trentm

plugins/node/opentelemetry-instrumentation-fastify/src/instrumentation.ts

@@ -21,7 +21,7 @@ import {
   InstrumentationNodeModuleDefinition,
   safeExecuteInTheMiddle,
 } from '@opentelemetry/instrumentation';
-import { SEMATTRS_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
+import { ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
 import type {
   HookHandlerDoneFunction,
   FastifyInstance,
@@ -269,7 +269,7 @@ export class FastifyInstrumentation extends InstrumentationBase<FastifyInstrumen
       const spanAttributes: Attributes = {
         [AttributeNames.PLUGIN_NAME]: this.pluginName,
         [AttributeNames.FASTIFY_TYPE]: FastifyTypes.REQUEST_HANDLER,
-        [SEMATTRS_HTTP_ROUTE]: anyRequest.routeOptions
+        [ATTR_HTTP_ROUTE]: anyRequest.routeOptions
           ? anyRequest.routeOptions.url // since [email protected]
           : request.routerPath,
       };

plugins/node/opentelemetry-instrumentation-fastify/test/instrumentation.test.ts

@@ -16,10 +16,7 @@
 
 import * as assert from 'assert';
 import { context, SpanStatusCode } from '@opentelemetry/api';
-import {
-  SEMATTRS_HTTP_ROUTE,
-  SEMATTRS_HTTP_METHOD,
-} from '@opentelemetry/semantic-conventions';
+import { ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
@@ -161,7 +158,7 @@ describe('fastify', () => {
       assert.deepStrictEqual(span.attributes, {
         'fastify.type': 'request_handler',
         'plugin.name': 'fastify -> @fastify/express',
-        [SEMATTRS_HTTP_ROUTE]: '/test',
+        [ATTR_HTTP_ROUTE]: '/test',
       });
       assert.strictEqual(
         span.name,
@@ -190,7 +187,7 @@ describe('fastify', () => {
         'fastify.type': 'request_handler',
         'fastify.name': 'namedHandler',
         'plugin.name': 'fastify -> @fastify/express',
-        [SEMATTRS_HTTP_ROUTE]: '/test',
+        [ATTR_HTTP_ROUTE]: '/test',
       });
       assert.strictEqual(span.name, 'request handler - namedHandler');
 
@@ -502,7 +499,7 @@ describe('fastify', () => {
     describe('using requestHook in config', () => {
       it('calls requestHook provided function when set in config', async () => {
         const requestHook = (span: Span, info: FastifyRequestInfo) => {
-          span.setAttribute(SEMATTRS_HTTP_METHOD, info.request.method);
+          span.setAttribute('my.http.method', info.request.method);
         };
 
         instrumentation.setConfig({
@@ -523,14 +520,14 @@ describe('fastify', () => {
         assert.deepStrictEqual(span.attributes, {
           'fastify.type': 'request_handler',
           'plugin.name': 'fastify -> @fastify/express',
-          [SEMATTRS_HTTP_ROUTE]: '/test',
-          [SEMATTRS_HTTP_METHOD]: 'GET',
+          [ATTR_HTTP_ROUTE]: '/test',
+          'my.http.method': 'GET',
         });
       });
 
       it('does not propagate an error from a requestHook that throws exception', async () => {
         const requestHook = (span: Span, info: FastifyRequestInfo) => {
-          span.setAttribute(SEMATTRS_HTTP_METHOD, info.request.method);
+          span.setAttribute('my.http.method', info.request.method);
 
           throw Error('error thrown in requestHook');
         };
@@ -553,8 +550,8 @@ describe('fastify', () => {
         assert.deepStrictEqual(span.attributes, {
           'fastify.type': 'request_handler',
           'plugin.name': 'fastify -> @fastify/express',
-          [SEMATTRS_HTTP_ROUTE]: '/test',
-          [SEMATTRS_HTTP_METHOD]: 'GET',
+          [ATTR_HTTP_ROUTE]: '/test',
+          'my.http.method': 'GET',
         });
       });
     });