fix(instrumentation-runtime-node): use the correct unit for eventloop.utilization (#2631)

maryliag · pichlermarc · web-flow · commit 3350583fd4b0 · 2025-01-09T17:16:22.000+01:00
Co-authored-by: Marc Pichler &lt;marc.pichler@dynatrace.com&gt;
diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts
@@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {
         `${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`,
         {
           description: 'Event loop utilization',
-          unit: 's',
+          unit: '1',
         }
       )
       .addCallback(async observableResult => {
diff --git a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts
@@ -90,7 +90,7 @@ describe(`${ConventionalNamePrefix.NodeJs}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}
 
     assert.strictEqual(
       utilizationMetric!.descriptor.unit,
-      's',
+      '1',
       'expected default unit'
     );
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {`
`38`	`38`	`${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`,
`39`	`39`	`{`
`40`	`40`	`description: 'Event loop utilization',`
`41`		`- unit: 's',`
	`41`	`+ unit: '1',`
`42`	`42`	`}`
`43`	`43`	`)`
`44`	`44`	`.addCallback(async observableResult => {`