Skip to content

Commit 3a02d5b

Browse files
committed
chore: address the PR feedback
Signed-off-by: Sudhanshu Pandey <[email protected]>
1 parent 2dfeeb5 commit 3a02d5b

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

examples/express/README.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,23 @@ shows key aspects of tracing such as
1717
npm install
1818
```
1919

20-
Setup [Jaeger Tracing](https://www.jaegertracing.io/docs/2.0/getting-started/#in-docker)
20+
Start Jaeger in Docker for receiving tracing data (see [the Jaeger docs](https://www.jaegertracing.io/docs/2.0/getting-started/#in-docker) for more details about running Jaeger):
21+
```bash
22+
docker run --rm --name jaeger \
23+
-p 5778:5778 \
24+
-p 16686:16686 \
25+
-p 4317:4317 \
26+
-p 4318:4318 \
27+
-p 14250:14250 \
28+
-p 14268:14268 \
29+
-p 9411:9411 \
30+
jaegertracing/jaeger:2.0.0 \
31+
--set receivers.otlp.protocols.http.endpoint=0.0.0.0:4318 \
32+
--set receivers.otlp.protocols.grpc.endpoint=0.0.0.0:4317
33+
```
2134

2235
## Run the Application
2336

24-
### Jaeger
25-
2637
Run the server:
2738

2839
```sh

examples/express/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"version": "0.1.0",
55
"description": "Example of Express integration with OpenTelemetry",
66
"scripts": {
7-
"jaeger:server": "cross-env EXPORTER=jaeger ts-node src/server.ts",
8-
"jaeger:client": "cross-env EXPORTER=jaeger ts-node src/client.ts",
7+
"server": "ts-node src/server.ts",
8+
"client": "ts-node src/client.ts",
99
"compile": "tsc -p ."
1010
},
1111
"repository": {

examples/express/src/tracer.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-proto';
1515
import { Resource } from '@opentelemetry/resources';
1616
import { ATTR_SERVICE_NAME, ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
1717

18-
const Exporter = OTLPTraceExporter;
1918
import { ExpressInstrumentation } from '@opentelemetry/instrumentation-express';
2019
import {HttpInstrumentation} from '@opentelemetry/instrumentation-http';
2120

@@ -35,7 +34,7 @@ export const setupTracing = (serviceName: string) => {
3534
],
3635
});
3736

38-
const exporter = new Exporter({});
37+
const exporter = new OTLPTraceExporter({});
3938

4039
provider.addSpanProcessor(new SimpleSpanProcessor(exporter));
4140

0 commit comments

Comments
 (0)