Skip to content

Commit 3a8406b

Browse files
authored
test(ioreids): disable client info for 5.8.0 and up (#3094)
1 parent cf9e2f5 commit 3a8406b

File tree

3 files changed

+27
-21
lines changed

3 files changed

+27
-21
lines changed

package-lock.json

Lines changed: 21 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/instrumentation-ioredis/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"@types/node": "18.18.14",
6565
"@types/sinon": "17.0.4",
6666
"cross-env": "7.0.3",
67-
"ioredis": "5.2.2",
67+
"ioredis": "5.8.0",
6868
"nyc": "17.1.0",
6969
"rimraf": "5.0.10",
7070
"sinon": "15.2.0",

packages/instrumentation-ioredis/test/ioredis.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,11 @@ describe('ioredis', () => {
166166
};
167167

168168
context.with(trace.setSpan(context.active(), span), () => {
169-
client = new ioredis(REDIS_URL);
169+
client = new ioredis(REDIS_URL, {
170+
// client info introduced in [email protected] - by disabling it we can ensure that assertions can remain
171+
// consistent with ioredis@<5.8.0.
172+
disableClientInfo: true,
173+
});
170174
client.on('ready', readyHandler);
171175
client.on('error', errorHandler);
172176
});

0 commit comments

Comments
 (0)