Skip to content

Commit 3ad305c

Browse files
committed
chore: update node versions in test workflows
1 parent 7ab5103 commit 3ad305c

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

.github/workflows/release-please.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ jobs:
1616
with:
1717
fetch-depth: 0
1818

19+
# If you update this version make sure to keep in sync:
20+
# - `build-and-cache` job of unit-test workflow
21+
# - `build-and-cache` job of test-all-versions workflow
1922
- name: Setup Node
2023
uses: actions/setup-node@v4
2124
with:

.github/workflows/test-all-versions.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@ jobs:
2525
uses: actions/checkout@v4
2626
with:
2727
fetch-depth: 0
28+
# Use the same Node.js version used for `release-please` workflow.
2829
- uses: actions/setup-node@v4
2930
with:
30-
node-version: 16
31+
node-version: 18
3132
- name: Install
3233
run: npm ci
3334
- name: Build

.github/workflows/unit-test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ jobs:
1717
uses: actions/checkout@v4
1818
with:
1919
fetch-depth: 0
20+
# Use the same Node.js version used for `release-please` workflow.
2021
- uses: actions/setup-node@v4
2122
with:
22-
node-version: 16
23+
node-version: 18
2324
- name: Install
2425
run: npm ci
2526
- name: Build
@@ -199,7 +200,7 @@ jobs:
199200
run: npm install -g npm@9 # npm@9 supports node >=14.17.0
200201
- name: Install
201202
run: npm ci
202-
- name: Dowload Artifacts
203+
- name: Download Build Artifacts
203204
uses: actions/download-artifact@v4
204205
with:
205206
name: tests-build-cache-${{ github.run_number }}

nx.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@
4040
]
4141
}
4242
}
43-
}
43+
}

0 commit comments

Comments
 (0)