Skip to content

Commit 3c600fe

Browse files
committed
- incorporate review comments
1 parent b3bc7eb commit 3c600fe

File tree

4 files changed

+328
-318
lines changed

4 files changed

+328
-318
lines changed

plugins/node/opentelemetry-instrumentation-oracledb/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ Caveats with ``oracledb`` Thick mode:
5050

5151
| Options | Type | Default | Description |
5252
| ------- | ---- | --------| ----------- |
53-
| `enhancedDatabaseReporting` | `boolean` | `false` | If true, additional details about the sql statement's bind values will be attached to the spans generated to represent the database operations |
54-
| `dbStatementDump` | `boolean` | `false` | If true, ``db.statement`` will contain the sql string in the spans generated |
53+
| `enhancedDatabaseReporting` | `boolean` | `false` | If true, additional details about the sql statement's bind values, ``db.operation.parameter.<key>`` will be attached to the spans generated to represent the database operations inaddition to the SQL statement in ``db.query.text`` |
54+
| `dbStatementDump` | `boolean` | `false` | If true, ``db.query.text`` will contain the sql string in the spans generated |
5555
| `requestHook` | `OracleInstrumentationExecutionRequestHook` (function) | | Function for adding custom span attributes using information about the data for the sql statement being executed |
5656
| `responseHook` | `OracleInstrumentationExecutionResponseHook` (function) | | Function for adding custom span attributes from the db response |
5757
| `requireParentSpan` | `boolean` | `false` | If true, requires a parent span to create new spans |

0 commit comments

Comments
 (0)