Skip to content

Commit 4a154e5

Browse files
committed
- Remove oracle specific attribute implicit_release as
suggested in semantic conventions review for now.
1 parent a0367cc commit 4a154e5

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

plugins/node/opentelemetry-instrumentation-oracledb/src/OracleTelemetryTraceHandler.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ type TraceHandlerBaseCtor = new () => any;
4545
const OUT_BIND = 3003; // bindinfo direction value.
4646

4747
// Local modules.
48-
import { AttributeNames } from './constants';
4948
import { OracleInstrumentationConfig, SpanConnectionConfig } from './types';
5049
import { TraceSpanData, SpanCallLevelConfig } from './internal-types';
5150
import { SpanNames, DB_SYSTEM_VALUE_ORACLE } from './constants';
@@ -329,12 +328,6 @@ export function getOracleTelemetryTraceHandlerClass(
329328
roundTrip
330329
);
331330
}
332-
if (traceContext.additionalConfig.implicitRelease) {
333-
span.setAttribute(
334-
AttributeNames.ORACLE_IMPLICIT_RELEASE,
335-
traceContext.additionalConfig.implicitRelease
336-
);
337-
}
338331
if (traceContext.error) {
339332
span.recordException(traceContext.error);
340333
span.setStatus({

plugins/node/opentelemetry-instrumentation-oracledb/src/constants.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@
1616
* Copyright (c) 2025, Oracle and/or its affiliates.
1717
* */
1818

19-
// Oracle specific attributes not covered by standard semantic conventions.
20-
// See: https://github.com/open-telemetry/semantic-conventions/pull/1911
21-
export enum AttributeNames {
22-
ORACLE_IMPLICIT_RELEASE = 'oracle.db.implicit_release',
23-
}
24-
2519
// Contains span names produced by instrumentation
2620
// It lists the RPC names (suffix with _MSG like EXECUTE_MSG) and
2721
// exported oracledb functions (like EXECUTE).

0 commit comments

Comments
 (0)