Skip to content

Commit 5efdd9d

Browse files
committed
chore(instrumentation-runtime-node): set default monitoringPrecision to 10ms, change scrape method to private
1 parent 6a84254 commit 5efdd9d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

plugins/node/instrumentation-runtime-node/src/instrumentation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { HeapSpacesSizeAndUsedCollector } from './metrics/heapSpacesSizeAndUsedC
2525
import { ConventionalNamePrefix } from './types/ConventionalNamePrefix';
2626

2727
const DEFAULT_CONFIG: RuntimeNodeInstrumentationConfig = {
28-
monitoringPrecision: 5000,
28+
monitoringPrecision: 10,
2929
};
3030

3131
export class RuntimeNodeInstrumentation extends InstrumentationBase {

plugins/node/instrumentation-runtime-node/src/metrics/eventLoopDelayCollector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class EventLoopDelayCollector extends BaseCollector {
167167
this._histogram.disable();
168168
}
169169

170-
protected scrape(): EventLoopLagInformation {
170+
private scrape(): EventLoopLagInformation {
171171
return {
172172
min: this.checkNan(this._histogram.min / 1e9),
173173
max: this.checkNan(this._histogram.max / 1e9),

plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class EventLoopUtilizationCollector extends BaseCollector {
5353

5454
protected internalEnable(): void {}
5555

56-
protected scrape(): EventLoopUtilization {
56+
private scrape(): EventLoopUtilization {
5757
return eventLoopUtilizationCollector();
5858
}
5959
}

plugins/node/instrumentation-runtime-node/src/metrics/heapSpacesSizeAndUsedCollector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export class HeapSpacesSizeAndUsedCollector extends BaseCollector {
124124

125125
internalDisable(): void {}
126126

127-
protected scrape(): HeapSpaceInfo[] {
127+
private scrape(): HeapSpaceInfo[] {
128128
return v8.getHeapSpaceStatistics();
129129
}
130130
}

0 commit comments

Comments
 (0)