Skip to content

Commit 6471e3e

Browse files
authored
Merge branch 'main' into trentm-semconv-up-instr-graphql
2 parents 5384ab2 + b698cb2 commit 6471e3e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

plugins/node/opentelemetry-instrumentation-pino/test/pino.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import * as sinon from 'sinon';
2222
import { INVALID_SPAN_CONTEXT, context, trace, Span } from '@opentelemetry/api';
2323
import { diag, DiagLogLevel } from '@opentelemetry/api';
2424
import { hrTimeToMilliseconds } from '@opentelemetry/core';
25-
import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
25+
import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
2626
import { resourceFromAttributes } from '@opentelemetry/resources';
2727
import {
2828
InMemorySpanExporter,
@@ -53,7 +53,7 @@ const tracer = tracerProvider.getTracer('default');
5353

5454
// Setup LoggerProvider for "log sending" tests.
5555
const resource = resourceFromAttributes({
56-
[SEMRESATTRS_SERVICE_NAME]: 'test-instrumentation-pino',
56+
[ATTR_SERVICE_NAME]: 'test-instrumentation-pino',
5757
});
5858
const loggerProvider = new LoggerProvider({ resource });
5959
const memExporter = new InMemoryLogRecordExporter();

plugins/node/opentelemetry-instrumentation-router/src/instrumentation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
InstrumentationNodeModuleFile,
2323
isWrapped,
2424
} from '@opentelemetry/instrumentation';
25-
import { SEMATTRS_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
25+
import { ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions';
2626

2727
import * as http from 'http';
2828
import type * as Router from 'router';
@@ -166,7 +166,7 @@ export class RouterInstrumentation extends InstrumentationBase {
166166
[AttributeNames.NAME]: fnName,
167167
[AttributeNames.VERSION]: this._moduleVersion,
168168
[AttributeNames.TYPE]: type,
169-
[SEMATTRS_HTTP_ROUTE]: route,
169+
[ATTR_HTTP_ROUTE]: route,
170170
};
171171

172172
const parent = api.context.active();

0 commit comments

Comments
 (0)