chorre: adjust versions to test

Author: david-luna

packages/instrumentation-knex/.tav.yml

@@ -1,10 +1,12 @@
 knex:
-  - versions:
-      include: '>=2 <4'
-      mode: max-5
-    commands: npm run test
-  - versions:
-      include: '>=0.10.0 <2'
-      mode: max-5
-    peerDependencies: "@vscode/sqlite3@^5.0.7"
-    commands: npm run test
+  jobs:
+    - versions:
+        include: ">=1.0.0 <2"
+        mode: max-3
+      peerDependencies: "@vscode/sqlite3@^5.0.7"
+      commands: npm run test
+    - versions:
+        include: ">=2.0.0 <4"
+        exclude: '3.0.0' # broken release
+        mode: max-3
+      commands: npm run test

packages/instrumentation-knex/package.json

@@ -17,7 +17,6 @@
     "prepublishOnly": "npm run compile",
     "tdd": "npm run test -- --watch-extensions ts --watch",
     "test": "nyc mocha 'test/**/*.ts'",
-    "//todo": "echo \"add test-all-versions\"",
     "test-all-versions": "tav",
     "version:update": "node ../../scripts/version-update.js",
     "watch": "tsc -w"
@@ -48,7 +47,6 @@
   "devDependencies": {
     "@opentelemetry/api": "^1.3.0",
     "@opentelemetry/context-async-hooks": "^2.0.0",
-    "@opentelemetry/contrib-test-utils": "^0.55.0",
     "@opentelemetry/sdk-trace-base": "^2.0.0",
     "@opentelemetry/sdk-trace-node": "^2.0.0",
     "better-sqlite3": "^11.10.0",

packages/instrumentation-knex/test/index.test.ts

@@ -27,12 +27,8 @@ import {
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
 import * as assert from 'assert';
-import * as semver from 'semver';
-import { getPackageVersion } from '@opentelemetry/contrib-test-utils';
 import { KnexInstrumentation } from '../src';
 
-const knexVersion = getPackageVersion('knex');
-
 const plugin = new KnexInstrumentation({
   maxQueryLength: 50,
 });
@@ -202,11 +198,6 @@ describe('Knex instrumentation', () => {
     });
 
     it('should catch better-sqlite3 errors', async function () {
-      // This dialect was added in v1.0.0
-      // ref: https://github.com/knex/knex/releases/tag/1.0.0
-      if (semver.lt(knexVersion, '1.0.0')) {
-        this.skip();
-      }
       client = knex({
         client: 'better-sqlite3',
         connection: {