Skip to content

Commit 98166fd

Browse files
committed
drop the TODO for review of db.namespace, this instr has no code owner :/
1 parent d3cc76b commit 98166fd

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/instrumentation-tedious/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,6 @@ Attributes collected:
6666
| `net.peer.name` | `server.address` | Remote hostname or similar. |
6767
| `net.peer.port` | `server.port` | Remote port number. |
6868

69-
XXX Get review from owner on db.namespace and lengthy rec from https://opentelemetry.io/docs/specs/semconv/database/sql-server/ note `[1]`.
70-
71-
7269
### Trace Context Propagation
7370

7471
Database trace context propagation can be enabled by setting `enableTraceContextPropagation`to `true`.

packages/instrumentation-tedious/src/instrumentation.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,9 @@ export class TediousInstrumentation extends InstrumentationBase<TediousInstrumen
247247
attributes[ATTR_DB_SQL_TABLE] = request.table;
248248
}
249249
if (thisPlugin._dbSemconvStability & SemconvStability.STABLE) {
250+
// The OTel spec for "db.namespace" discusses handling for connection
251+
// to MSSQL "named instances". This isn't currently supported.
252+
// https://opentelemetry.io/docs/specs/semconv/database/sql-server/#:~:text=%5B1%5D%20db%2Enamespace
250253
attributes[ATTR_DB_NAMESPACE] = databaseName;
251254
attributes[ATTR_DB_SYSTEM_NAME] = DB_SYSTEM_NAME_VALUE_MICROSOFT_SQL_SERVER;
252255
attributes[ATTR_DB_QUERY_TEXT] = sql;

0 commit comments

Comments
 (0)