File tree Expand file tree Collapse file tree 2 files changed +3
-3
lines changed
packages/instrumentation-tedious Expand file tree Collapse file tree 2 files changed +3
-3
lines changed Original file line number Diff line number Diff line change @@ -66,9 +66,6 @@ Attributes collected:
6666| ` net.peer.name ` | ` server.address ` | Remote hostname or similar. |
6767| ` net.peer.port ` | ` server.port ` | Remote port number. |
6868
69- XXX Get review from owner on db.namespace and lengthy rec from https://opentelemetry.io/docs/specs/semconv/database/sql-server/ note ` [1] ` .
70-
71-
7269### Trace Context Propagation
7370
7471Database trace context propagation can be enabled by setting ` enableTraceContextPropagation ` to ` true ` .
Original file line number Diff line number Diff line change @@ -247,6 +247,9 @@ export class TediousInstrumentation extends InstrumentationBase<TediousInstrumen
247247 attributes [ ATTR_DB_SQL_TABLE ] = request . table ;
248248 }
249249 if ( thisPlugin . _dbSemconvStability & SemconvStability . STABLE ) {
250+ // The OTel spec for "db.namespace" discusses handling for connection
251+ // to MSSQL "named instances". This isn't currently supported.
252+ // https://opentelemetry.io/docs/specs/semconv/database/sql-server/#:~:text=%5B1%5D%20db%2Enamespace
250253 attributes [ ATTR_DB_NAMESPACE ] = databaseName ;
251254 attributes [ ATTR_DB_SYSTEM_NAME ] = DB_SYSTEM_NAME_VALUE_MICROSOFT_SQL_SERVER ;
252255 attributes [ ATTR_DB_QUERY_TEXT ] = sql ;
You can’t perform that action at this time.
0 commit comments