Skip to content

Commit 9ff500b

Browse files
committed
instr-cucumber
1 parent af81042 commit 9ff500b

File tree

3 files changed

+214
-18
lines changed

3 files changed

+214
-18
lines changed

package-lock.json

Lines changed: 203 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/node/instrumentation-cucumber/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"author": "OpenTelemetry Authors",
3030
"license": "Apache-2.0",
3131
"engines": {
32-
"node": ">=14"
32+
"node": "^18.19.0 || >=20.6.0"
3333
},
3434
"files": [
3535
"build/src/**/*.js",
@@ -46,9 +46,9 @@
4646
"@cucumber/cucumber": "^9.0.0",
4747
"@cucumber/messages": "^22.0.0",
4848
"@opentelemetry/api": "^1.0.0",
49-
"@opentelemetry/core": "^1.3.1",
50-
"@opentelemetry/sdk-trace-base": "^1.3.1",
51-
"@opentelemetry/sdk-trace-node": "^1.3.1",
49+
"@opentelemetry/core": "^2.0.0-dev.1",
50+
"@opentelemetry/sdk-trace-base": "^2.0.0-dev.1",
51+
"@opentelemetry/sdk-trace-node": "^2.0.0-dev.1",
5252
"@types/mocha": "10.0.10",
5353
"@types/node": "18.18.14",
5454
"@types/semver": "7.5.8",
@@ -62,7 +62,7 @@
6262
"typescript": "4.4.4"
6363
},
6464
"dependencies": {
65-
"@opentelemetry/instrumentation": "^0.57.2",
65+
"@opentelemetry/instrumentation": "^0.200.0-dev.1",
6666
"@opentelemetry/semantic-conventions": "^1.27.0"
6767
},
6868
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-cucumber#readme"

plugins/node/instrumentation-cucumber/test/cucumber.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
SEMATTRS_CODE_NAMESPACE,
2929
SEMRESATTRS_SERVICE_NAME,
3030
} from '@opentelemetry/semantic-conventions';
31-
import { Resource } from '@opentelemetry/resources';
31+
import { resourceFromAttributes } from '@opentelemetry/resources';
3232

3333
import * as path from 'path';
3434
import * as assert from 'assert';
@@ -56,7 +56,7 @@ describe('CucumberInstrumentation', () => {
5656
const memoryExporter = new InMemorySpanExporter();
5757
const spanProcessor = new SimpleSpanProcessor(memoryExporter);
5858
const provider = new NodeTracerProvider({
59-
resource: new Resource({
59+
resource: resourceFromAttributes({
6060
[SEMRESATTRS_SERVICE_NAME]: 'CucumberInstrumentation',
6161
}),
6262
spanProcessors: [spanProcessor],
@@ -281,7 +281,7 @@ describe('CucumberInstrumentation', () => {
281281
assert.equal(attemptSpans.length, 3);
282282

283283
assert.deepEqual(
284-
attemptSpans.map(span => span.parentSpanId),
284+
attemptSpans.map(span => span.parentSpanContext?.spanId),
285285
Array(3).fill(parent.spanContext().spanId)
286286
);
287287
});
@@ -296,7 +296,9 @@ describe('CucumberInstrumentation', () => {
296296
attemptSpans.forEach(attempt => {
297297
assert.equal(
298298
spans.filter(
299-
span => span.parentSpanId === attempt.spanContext().spanId
299+
span =>
300+
span.parentSpanContext?.spanId ===
301+
attempt.spanContext().spanId
300302
).length,
301303
4
302304
);

0 commit comments

Comments
 (0)