Skip to content

Commit a3ac2f2

Browse files
committed
chore: fix conflicts with main
1 parent 2888fc4 commit a3ac2f2

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

packages/instrumentation-pg/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"lint:readme": "node ../../scripts/lint-readme.js",
1919
"prepublishOnly": "npm run compile",
2020
"tdd": "npm run test -- --watch-extensions ts --watch",
21-
"test": "cat test/pg-pool.test.ts nyc mocha 'test/**/*.test.ts'",
21+
"test": "nyc mocha 'test/**/*.test.ts'",
2222
"test:debug": "mocha --inspect-brk --no-timeouts 'test/**/*.test.ts'",
2323
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test",
2424
"test-all-versions": "tav",

packages/instrumentation-pg/test/pg-pool.test.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -982,9 +982,8 @@ describe('pg semantic conventions env variable', () => {
982982
const provider = new BasicTracerProvider({
983983
spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
984984
});
985-
const testPostgres = process.env.RUN_POSTGRES_TESTS; // For CI: assumes local postgres db is already available
986-
const testPostgresLocally = process.env.RUN_POSTGRES_TESTS_LOCAL; // For local: spins up local postgres db via docker
987-
const shouldTest = testPostgres || testPostgresLocally; // Skips these tests if false (default)
985+
const testPostgres = process.env.RUN_POSTGRES_TESTS;
986+
const shouldTest = testPostgres;
988987
// Here we are `require`ing *before* the instrumentation is created below.
989988
// In *general* this is a potential instrumentation issue, but this works for
990989
// `pg-pool` instrumentation because it patches the `pgPool.prototype`
@@ -1003,23 +1002,13 @@ describe('pg semantic conventions env variable', () => {
10031002
if (!shouldTest) {
10041003
skip();
10051004
}
1006-
1007-
if (testPostgresLocally) {
1008-
testUtils.startDocker('postgres');
1009-
}
10101005
});
10111006

10121007
beforeEach(() => {
10131008
contextManager = new AsyncLocalStorageContextManager().enable();
10141009
context.setGlobalContextManager(contextManager);
10151010
});
10161011

1017-
after(() => {
1018-
if (testPostgresLocally) {
1019-
testUtils.cleanUpDocker('postgres');
1020-
}
1021-
});
1022-
10231012
afterEach(() => {
10241013
delete process.env.OTEL_SEMCONV_STABILITY_OPT_IN;
10251014
memoryExporter.reset();

0 commit comments

Comments
 (0)