fix(instrumentation-kafkajs): check for definedness, not truthiness on partition IDs

a message with a partition ID of `0` should now have the proper
attribute set

Author: brianphillips

plugins/node/instrumentation-kafkajs/src/instrumentation.ts

@@ -516,7 +516,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
                 [ATTR_MESSAGING_SYSTEM]: MESSAGING_SYSTEM_VALUE_KAFKA,
                 [ATTR_MESSAGING_OPERATION_NAME]: 'send',
                 [ATTR_MESSAGING_DESTINATION_NAME]: topicMessage.topic,
-                ...(message.partition
+                ...(message.partition !== undefined
                   ? {
                       [ATTR_MESSAGING_DESTINATION_PARTITION_ID]: String(
                         message.partition
@@ -557,7 +557,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
             [ATTR_MESSAGING_SYSTEM]: MESSAGING_SYSTEM_VALUE_KAFKA,
             [ATTR_MESSAGING_OPERATION_NAME]: 'send',
             [ATTR_MESSAGING_DESTINATION_NAME]: record.topic,
-            ...(m.partition
+            ...(m.partition !== undefined
               ? {
                   [ATTR_MESSAGING_DESTINATION_PARTITION_ID]: String(
                     m.partition
@@ -681,9 +681,10 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
           : undefined,
         [ATTR_MESSAGING_KAFKA_MESSAGE_TOMBSTONE]:
           message.key && message.value === null ? true : undefined,
-        [ATTR_MESSAGING_DESTINATION_PARTITION_ID]: message.partition
-          ? String(message.partition)
-          : undefined,
+        [ATTR_MESSAGING_DESTINATION_PARTITION_ID]:
+          message.partition !== undefined
+            ? String(message.partition)
+            : undefined,
         [ATTR_MESSAGING_OPERATION_NAME]: 'send',
         [ATTR_MESSAGING_OPERATION_TYPE]: MESSAGING_OPERATION_TYPE_VALUE_SEND,
       },

plugins/node/instrumentation-kafkajs/test/kafkajs.test.ts

@@ -323,9 +323,11 @@ describe('instrumentation-kafkajs', () => {
           topic: 'topic-name-1',
           messages: [
             {
+              partition: 0,
               value: 'message1',
             },
             {
+              partition: 0,
               value: 'message2',
             },
           ],
@@ -352,6 +354,7 @@ describe('instrumentation-kafkajs', () => {
               attributes: {
                 [ATTR_MESSAGING_SYSTEM]: MESSAGING_SYSTEM_VALUE_KAFKA,
                 [ATTR_MESSAGING_DESTINATION_NAME]: 'topic-name-1',
+                [ATTR_MESSAGING_DESTINATION_PARTITION_ID]: '0',
                 [ATTR_MESSAGING_OPERATION_NAME]: 'send',
               },
             },
@@ -400,6 +403,7 @@ describe('instrumentation-kafkajs', () => {
               topic: 'topic-name-2',
               messages: [
                 {
+                  partition: 1,
                   value: 'message2-1',
                 },
               ],
@@ -435,6 +439,7 @@ describe('instrumentation-kafkajs', () => {
               attributes: {
                 [ATTR_MESSAGING_SYSTEM]: MESSAGING_SYSTEM_VALUE_KAFKA,
                 [ATTR_MESSAGING_DESTINATION_NAME]: 'topic-name-2',
+                [ATTR_MESSAGING_DESTINATION_PARTITION_ID]: '1',
                 [ATTR_MESSAGING_OPERATION_NAME]: 'send',
               },
             },