chore: update release validate workflow

Author: david-luna

.github/workflows/release-please-validate.yaml

@@ -15,8 +15,8 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Install lerna
-        run: npm install -g [email protected]
+      - name: Install glob
+        run: npm install glob
 
       - name: Ensure Release Please Config and Manifest are in sync with the repository
         run: node scripts/check-release-please.mjs

package-lock.json

@@ -50,12 +50,12 @@
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-prettier": "4.2.1",
-    "glob": "^10.3.10",
+    "glob": "^10.4.5",
     "lerna-changelog": "2.2.0",
     "markdownlint-cli2": "0.13.0",
     "minimatch": "^9.0.3",
-    "nx": "15.9.7",
     "mocha": "^10.7.3",
+    "nx": "15.9.7",
     "prettier": "2.8.8",
     "process": "0.11.10",
     "semver": "^7.6.0",

package.json

@@ -1,7 +1,6 @@
-import { strict as assert } from 'assert';
-import * as childProcess from 'child_process';
 import path from 'path';
 import { readFileSync } from 'fs';
+import { globSync } from 'glob';
 
 /*
 	Enumerates through
@@ -23,28 +22,32 @@ const PROJECT_ROOT = process.cwd();
 const readJson = (filePath) => {
 	return JSON.parse(readFileSync(filePath));
 };
-const getProcessOutput = (cmd, args) => {
-	const result = childProcess.spawnSync(cmd, args);
-	assert(!result.error, result.error);
-	return result.stdout.toString('utf8');
+
+const getPackages = () => {
+	const TOP = process.cwd();
+	const pj = readJson(path.join(TOP, 'package.json'));
+	return pj.workspaces
+		.map((wsGlob) => globSync(path.join(wsGlob, 'package.json')))
+		.flat()
+		.map((p) => {
+			const pkgInfo = readJson(p);
+			pkgInfo.location = path.dirname(p);
+			pkgInfo.relativeLocation = path.relative(PROJECT_ROOT, pkgInfo.location);
+			return pkgInfo;
+		});
 }
 
-const lernaList = JSON
-	.parse(getProcessOutput('npx', ['lerna', 'list', '--json', '-a']))
-	.map((pkgInfo) => {
-		pkgInfo.relativeLocation = path.relative(PROJECT_ROOT, pkgInfo.location);
-		return pkgInfo;
-	});
+const pkgList = getPackages();
 const manifest = readJson('.release-please-manifest.json');
 const config = readJson('release-please-config.json');
 
-const lernaPackages = new Set(
-  lernaList.map((pkgInfo) => pkgInfo.relativeLocation)
+const packageLocations = new Set(
+  pkgList.map((pkgInfo) => pkgInfo.relativeLocation)
 );
 const manifestPackages = new Set(Object.keys(manifest));
 const configPackages = new Set(Object.keys(config.packages));
 
-lernaList.forEach((pkgInfo) => {
+pkgList.forEach((pkgInfo) => {
   const relativeLocation = pkgInfo.relativeLocation
   if (pkgInfo.private) {
     // Should be in config, with `skip-github-release` option.
@@ -71,14 +74,14 @@ lernaList.forEach((pkgInfo) => {
 
 manifestPackages.forEach((relativeLocation) => {
 	logErrorIf(
-		!lernaPackages.has(relativeLocation),
+		!packageLocations.has(relativeLocation),
 		`Extraneous path ${relativeLocation} in .release-please-manifest.json`
 	);
 });
 
 configPackages.forEach((relativeLocation) => {
 	logErrorIf(
-		!lernaPackages.has(relativeLocation),
+		!packageLocations.has(relativeLocation),
 		`Extraneous path ${relativeLocation} in release-please-config.json`
 	);
 });