Skip to content

Commit afa8217

Browse files
committed
Fix lint errors
1 parent 611de0a commit afa8217

File tree

6 files changed

+10
-37
lines changed

6 files changed

+10
-37
lines changed

packages/esbuild-plugin-node/src/config/main.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import {
1818
Instrumentation,
1919
InstrumentationBase,
20-
InstrumentationModuleDefinition,
2120
} from '@opentelemetry/instrumentation';
2221

2322
import { EsbuildInstrumentationConfigMap } from '../types';
@@ -31,9 +30,8 @@ function getModuleDefinitions(instrumentation: Instrumentation) {
3130
return [];
3231
}
3332

34-
export const instrumentations: InstrumentationModuleDefinition<any>[] =
33+
export const instrumentations =
3534
getNodeAutoInstrumentations().flatMap(getModuleDefinitions);
36-
// console.log({ instrumentations });
3735

3836
function configGenerator<T extends { enabled?: boolean }>(
3937
config?: T

packages/esbuild-plugin-node/src/plugin.test.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

packages/esbuild-plugin-node/src/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ function dotFriendlyResolve(path: string, directory: string): string {
131131
* input: '/foo/node_modules/@co/stuff/foo/bar/baz.js'
132132
* output: { package: '@co/stuff', path: 'foo/bar/baz.js' }
133133
*/
134-
export function extractPackageAndModulePath(
134+
function extractPackageAndModulePath(
135135
path: string,
136136
resolveDir: string
137137
): { path: string; extractedModule: ExtractedModule } {

packages/esbuild-plugin-node/src/types.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@
1717
import type { OnLoadArgs as EsbuildOnLoadArgs } from 'esbuild';
1818
import type { InstrumentationConfigMap } from '@opentelemetry/auto-instrumentations-node';
1919

20-
// TODO: Get all names
21-
export type InstrumentedPackage =
22-
| 'fastify'
23-
| 'pino'
24-
| '@smithy/smithy-client'
25-
| '@smithy/middleware-stack';
26-
2720
export interface ExtractedModule {
2821
package: string | null;
2922
path: string | null;
@@ -32,9 +25,9 @@ export interface ExtractedModule {
3225
export type OnLoadArgs = Omit<EsbuildOnLoadArgs, 'pluginData'> & {
3326
pluginData?: {
3427
shouldPatchPackage: boolean;
35-
package: InstrumentedPackage;
28+
package: string;
3629
instrumentation: {
37-
name: InstrumentedPackage;
30+
name: string;
3831
};
3932
extractedModule: ExtractedModule;
4033
};

packages/esbuild-plugin-node/test/plugin.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717
import * as assert from 'assert';
1818

1919
import { exec as execCb, spawnSync } from 'child_process';
20-
import { inspect, promisify } from 'util';
20+
21+
import { promisify } from 'util';
2122

2223
const exec = promisify(execCb);
2324

packages/esbuild-plugin-node/test/test-app/graphql/adapter.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ interface GraphQLArgs {
4040
typeResolver?: Maybe<GraphQLTypeResolver<any, any>>;
4141
}
4242

43-
const executeGraphqlQuery = (queryFunc: Function, args: GraphQLArgs) => {
43+
const executeGraphqlQuery = (
44+
queryFunc: (...args: unknown[]) => unknown,
45+
args: GraphQLArgs
46+
) => {
4447
const pre16Version =
4548
!version || version.startsWith('14.') || version.startsWith('15.');
4649
if (pre16Version) {

0 commit comments

Comments
 (0)