cleaning up tests

Author: facostaembrace

plugins/node/instrumentation-react-native-navigation/test/NativeNavigationTracker.test.tsx

@@ -21,19 +21,21 @@ import sinon from 'sinon';
 import { NativeNavigationTracker } from '../src';
 import useProvider from './helpers/hooks/useProvider';
 import api from '@opentelemetry/api';
-import * as rnn from './helpers/react-native-navigation';
-import {
-  INativeNavigationContainer,
-  NavigationTrackerConfig,
-} from '../src/types/navigation';
+import { TrackerConfig } from '../src/types/navigation';
+
+const sandbox = sinon.createSandbox();
+const mockDidAppearListener = sandbox.spy();
+const mockDidDisappearListener = sandbox.spy();
 
 const AppWithProvider: FC<{
   shouldPassProvider: boolean;
-  config?: NavigationTrackerConfig;
+  config?: TrackerConfig;
 }> = ({ shouldPassProvider, config }) => {
-  const { Navigation } = rnn;
   const provider = useProvider();
-  const ref = useRef(Navigation.events());
+  const ref = useRef({
+    registerComponentDidAppearListener: mockDidAppearListener,
+    registerComponentDidDisappearListener: mockDidDisappearListener,
+  });
 
   return (
     <NativeNavigationTracker
@@ -47,10 +49,6 @@ const AppWithProvider: FC<{
 };
 
 describe('NativeNavigationTracker.tsx', function () {
-  const sandbox = sinon.createSandbox();
-  const mockDidAppearListener = sandbox.spy();
-  const mockDidDisappearListener = sandbox.spy();
-
   let mockConsoleDir: sinon.SinonSpy;
   let mockConsoleInfo: sinon.SinonSpy;
   let mockConsoleWarn: sinon.SinonSpy;
@@ -59,12 +57,6 @@ describe('NativeNavigationTracker.tsx', function () {
   let mockGlobalTracer: sinon.SinonSpy;
 
   beforeEach(function () {
-    const { Navigation } = rnn;
-    sandbox.stub(Navigation, 'events').returns({
-      registerComponentDidAppearListener: mockDidAppearListener,
-      registerComponentDidDisappearListener: mockDidDisappearListener,
-    } as unknown as INativeNavigationContainer);
-
     mockAddEventListener = sandbox.spy(AppState, 'addEventListener');
     mockConsoleDir = sandbox.spy(console, 'dir');
     mockConsoleInfo = sandbox.spy(console, 'info');

plugins/node/instrumentation-react-native-navigation/test/NavigationTracker.test.tsx

@@ -13,32 +13,38 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { FC, ForwardedRef } from 'react';
+import { FC } from 'react';
 import React, { render } from '@testing-library/react';
 
 import useProvider from './helpers/hooks/useProvider';
 
-import { NavRef } from '../src/hooks/useNavigationTracker';
 import { ATTRIBUTES } from '../src/utils/spanFactory';
 import sinon from 'sinon';
 import { NavigationTracker } from '../src';
 
 import { AppState } from 'react-native';
 import api from '@opentelemetry/api';
-import * as rnn from './helpers/react-navigation-native';
-import { NavigationTrackerConfig } from '../src/types/navigation';
+import { TrackerConfig } from '../src/types/navigation';
+
+const sandbox = sinon.createSandbox();
+
+const mockAddListener = sandbox.stub();
+const mockGetCurrentRoute = sandbox.stub();
 
 const AppWithProvider: FC<{
   shouldPassProvider: boolean;
-  config?: NavigationTrackerConfig;
+  config?: TrackerConfig;
 }> = ({ shouldPassProvider, config }) => {
-  const { useNavigationContainerRef } = rnn;
-  const ref = useNavigationContainerRef();
   const provider = useProvider();
 
   return (
     <NavigationTracker
-      ref={ref as unknown as ForwardedRef<NavRef>}
+      ref={{
+        current: {
+          getCurrentRoute: mockGetCurrentRoute,
+          addListener: mockAddListener,
+        },
+      }}
       config={config}
       provider={shouldPassProvider ? provider.current : undefined}
     >
@@ -48,11 +54,6 @@ const AppWithProvider: FC<{
 };
 
 describe('NavigationTracker.tsx', function () {
-  const sandbox = sinon.createSandbox();
-
-  const mockAddListener = sandbox.stub();
-  const mockGetCurrentRoute = sandbox.stub();
-
   let mockAddEventListener: sinon.SinonSpy;
   let mockConsoleDir: sinon.SinonSpy;
   let mockConsoleInfo: sinon.SinonSpy;
@@ -61,16 +62,6 @@ describe('NavigationTracker.tsx', function () {
   let mockGlobalTracer: sinon.SinonSpy;
 
   beforeEach(function () {
-    sandbox.stub(rnn, 'useNavigationContainerRef').callsFake(
-      () =>
-        ({
-          current: {
-            getCurrentRoute: mockGetCurrentRoute,
-            addListener: mockAddListener,
-          },
-        } as unknown as ReturnType<typeof rnn.useNavigationContainerRef>)
-    );
-
     mockAddEventListener = sandbox.spy(AppState, 'addEventListener');
     mockConsoleDir = sandbox.spy(console, 'dir');
     mockConsoleInfo = sandbox.spy(console, 'info');