Skip to content

Commit b5c7e24

Browse files
committed
instr-knex
1 parent 43fefee commit b5c7e24

File tree

3 files changed

+207
-15
lines changed

3 files changed

+207
-15
lines changed

package-lock.json

Lines changed: 201 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/node/opentelemetry-instrumentation-knex/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"author": "OpenTelemetry Authors",
2929
"license": "Apache-2.0",
3030
"engines": {
31-
"node": ">=14"
31+
"node": "^18.19.0 || >=20.6.0"
3232
},
3333
"files": [
3434
"build/src/**/*.js",
@@ -43,9 +43,9 @@
4343
},
4444
"devDependencies": {
4545
"@opentelemetry/api": "^1.3.0",
46-
"@opentelemetry/context-async-hooks": "^1.8.0",
47-
"@opentelemetry/sdk-trace-base": "^1.8.0",
48-
"@opentelemetry/sdk-trace-node": "^1.8.0",
46+
"@opentelemetry/context-async-hooks": "^2.0.0-dev.1",
47+
"@opentelemetry/sdk-trace-base": "^2.0.0-dev.1",
48+
"@opentelemetry/sdk-trace-node": "^2.0.0-dev.1",
4949
"@types/mocha": "10.0.10",
5050
"@types/node": "18.18.14",
5151
"better-sqlite3": "11.0.0",
@@ -56,7 +56,7 @@
5656
"typescript": "4.4.4"
5757
},
5858
"dependencies": {
59-
"@opentelemetry/instrumentation": "^0.57.2",
59+
"@opentelemetry/instrumentation": "^0.200.0-dev.1",
6060
"@opentelemetry/semantic-conventions": "^1.27.0"
6161
},
6262
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-knex#readme"

plugins/node/opentelemetry-instrumentation-knex/test/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ const assertSpans = (
624624
);
625625
assert.strictEqual(span.attributes['db.operation'], expected.op);
626626
assert.strictEqual(
627-
span.parentSpanId,
627+
span.parentSpanContext?.spanId,
628628
expected.parentSpan?.spanContext().spanId
629629
);
630630
} catch (e: any) {

0 commit comments

Comments
 (0)