chore(instrumentation-kafkajs): enable test coverage reporting

Author: brianphillips

plugins/node/instrumentation-kafkajs/package.json

@@ -6,7 +6,7 @@
   "types": "build/src/index.d.ts",
   "repository": "open-telemetry/opentelemetry-js-contrib",
   "scripts": {
-    "test": "mocha --require @opentelemetry/contrib-test-utils 'test/**/*.test.ts'",
+    "test": "nyc mocha --require @opentelemetry/contrib-test-utils 'test/**/*.test.ts'",
     "tdd": "npm run test -- --watch-extensions ts --watch",
     "clean": "rimraf build/*",
     "lint": "eslint . --ext .ts",

plugins/node/instrumentation-kafkajs/src/instrumentation.ts

@@ -84,7 +84,7 @@ interface ConsumerSpanOptions {
   topic: string;
   message: KafkaMessage | undefined;
   operationType: string;
-  attributes?: Attributes;
+  attributes: Attributes;
   ctx?: Context | undefined;
   link?: Link;
 }
@@ -583,9 +583,9 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
         return result;
       })
       .catch(reason => {
-        let errorMessage: string;
-        let errorType = ERROR_TYPE_VALUE_OTHER;
-        if (typeof reason === 'string') {
+        let errorMessage: string | undefined;
+        let errorType: string = ERROR_TYPE_VALUE_OTHER;
+        if (typeof reason === 'string' || reason === undefined) {
           errorMessage = reason;
         } else if (
           typeof reason === 'object' &&
@@ -597,7 +597,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
         pendingMetrics.forEach(m => m(errorType));
 
         spans.forEach(span => {
-          if (errorType) span.setAttribute(ATTR_ERROR_TYPE, errorType);
+          span.setAttribute(ATTR_ERROR_TYPE, errorType);
           span.setStatus({
             code: SpanStatusCode.ERROR,
             message: errorMessage,
@@ -617,7 +617,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
     operationType,
     ctx,
     link,
-    attributes = {},
+    attributes,
   }: ConsumerSpanOptions) {
     const operationName =
       operationType === MESSAGING_OPERATION_TYPE_VALUE_RECEIVE
@@ -641,7 +641,7 @@ export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumen
             ? String(message.key)
             : undefined,
           [ATTR_MESSAGING_KAFKA_MESSAGE_TOMBSTONE]:
-            message?.key && message?.value === null ? true : undefined,
+            message?.key && message.value === null ? true : undefined,
           [ATTR_MESSAGING_KAFKA_OFFSET]: message?.offset,
         },
         links: link ? [link] : [],