Skip to content

Commit bd833d9

Browse files
committed
test(aws-sdk): re-introduce checks for past versions
1 parent 8f4c9ac commit bd833d9

File tree

1 file changed

+9
-2
lines changed
  • plugins/node/opentelemetry-instrumentation-aws-sdk

1 file changed

+9
-2
lines changed
Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
1+
# Versions [3.363.0, 3.377.0] of all @aws-sdk/client-* were bad releases. See:
2+
# - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464#issuecomment-2403652552
3+
# - https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719
4+
15
# node version support in JS SDK v3:
26
# - 16.x dropped in v3.723.0 https://github.com/aws/aws-sdk-js-v3/pull/6775
37

48
'@aws-sdk/client-s3':
9+
# - 3.529.0 was missing the fast-xml-parser dependency (https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.529.1)
510
jobs:
611
- node: '>=18'
712
versions:
8-
include: '>=v3.723.0'
13+
include: '^3.6.1'
14+
exclude: '3.529.0 || >=3.363.0 <=3.377.0'
915
mode: 'max-7'
1016
commands:
1117
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-s3.test.ts
@@ -15,7 +21,8 @@
1521
jobs:
1622
- node: '>=18'
1723
versions:
18-
include: '>=v3.723.0'
24+
include: '^3.24.0'
25+
exclude: '>=3.363.0 <=3.377.0'
1926
mode: 'max-7'
2027
commands:
2128
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-sqs.test.ts

0 commit comments

Comments
 (0)