chore: add InstrumentationConnection to avoid as any casts

Author: lucas-gregoire

packages/instrumentation-amqplib/src/amqplib.ts

@@ -65,6 +65,7 @@ import {
   CONNECTION_ATTRIBUTES,
   getConnectionAttributesFromServer,
   getConnectionAttributesFromUrl,
+  InstrumentationConnection,
   InstrumentationConsumeChannel,
   InstrumentationConsumeMessage,
   InstrumentationMessage,
@@ -254,11 +255,11 @@ export class AmqplibInstrumentation extends InstrumentationBase<AmqplibInstrumen
         this,
         url,
         socketOptions,
-        function (this: unknown, err, conn: Connection) {
+        function (this: unknown, err, conn: InstrumentationConnection) {
           if (err == null) {
             const urlAttributes = getConnectionAttributesFromUrl(url);
             const serverAttributes = getConnectionAttributesFromServer(conn);
-            (conn as any)[CONNECTION_ATTRIBUTES] = {
+            conn[CONNECTION_ATTRIBUTES] = {
               ...urlAttributes,
               ...serverAttributes,
             };

packages/instrumentation-amqplib/src/utils.ts

@@ -45,12 +45,15 @@ export const CONNECTION_ATTRIBUTES: unique symbol = Symbol(
   'opentelemetry.amqplib.connection.attributes'
 );
 
+export type InstrumentationConnection = amqp.Connection & {
+  [CONNECTION_ATTRIBUTES]?: Attributes;
+};
 export type InstrumentationPublishChannel = (
   | amqp.Channel
   | amqp.ConfirmChannel
-) & { connection: { [CONNECTION_ATTRIBUTES]: Attributes } };
+) & { connection: InstrumentationConnection };
 export type InstrumentationConsumeChannel = amqp.Channel & {
-  connection: { [CONNECTION_ATTRIBUTES]: Attributes };
+  connection: InstrumentationConnection;
   [CHANNEL_SPANS_NOT_ENDED]?: {
     msg: amqp.ConsumeMessage;
     timeOfConsume: HrTime;