Skip to content

Commit c5d273a

Browse files
committed
test(aws-sdk): remove runs for Node.js <18.x
1 parent 37d8ce1 commit c5d273a

File tree

1 file changed

+8
-47
lines changed
  • plugins/node/opentelemetry-instrumentation-aws-sdk

1 file changed

+8
-47
lines changed
Lines changed: 8 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,67 +1,28 @@
11
# Note: tests must set `SKIP_TEST_IF_DISABLE=true` to override usage of
22
# `mocha --require '../../../scripts/skip-test-if.js' ...` if calling `npm test`.
33

4-
# Versions [3.363.0, 3.377.0] of all @aws-sdk/client-* were bad releases. See:
5-
# - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464#issuecomment-2403652552
6-
# - https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719
7-
84
# node version support in JS SDK v3:
9-
# - 14.x dropped in v3.567.0 https://github.com/aws/aws-sdk-js-v3/pull/6034
105
# - 16.x dropped in v3.723.0 https://github.com/aws/aws-sdk-js-v3/pull/6775
116

12-
"@aws-sdk/client-s3":
7+
'@aws-sdk/client-s3':
138
env:
149
- SKIP_TEST_IF_DISABLE=true
15-
# - 3.529.0 was missing the fast-xml-parser dependency (https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.529.1)
1610
jobs:
17-
- node: ">=18"
18-
versions:
19-
include: "^3.6.1"
20-
exclude: "3.529.0 || >=3.363.0 <=3.377.0"
21-
mode: "max-7"
22-
commands:
23-
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-s3.test.ts
24-
- mocha --require '@opentelemetry/contrib-test-utils' test/s3.test.ts
25-
- node: "16"
26-
versions:
27-
include: ">=3.6.1 <3.723.0"
28-
exclude: "3.529.0 || >=3.363.0 <=3.377.0"
29-
mode: "max-7"
30-
commands:
31-
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-s3.test.ts
32-
- mocha --require '@opentelemetry/contrib-test-utils' test/s3.test.ts
33-
- node: "14"
11+
- node: '>=18'
3412
versions:
35-
include: ">=3.6.1 <3.567.0"
36-
exclude: "3.529.0 || >=3.363.0 <=3.377.0"
37-
mode: "max-7"
13+
include: '>=v3.723.0'
14+
mode: 'max-7'
3815
commands:
3916
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-s3.test.ts
4017
- mocha --require '@opentelemetry/contrib-test-utils' test/s3.test.ts
4118

42-
"@aws-sdk/client-sqs":
19+
'@aws-sdk/client-sqs':
4320
env:
4421
- SKIP_TEST_IF_DISABLE=true
4522
jobs:
46-
- node: ">=18"
47-
versions:
48-
include: "^3.24.0"
49-
exclude: ">=3.363.0 <=3.377.0"
50-
mode: "max-7"
51-
commands:
52-
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-sqs.test.ts
53-
- node: "16"
23+
- node: '>=18'
5424
versions:
55-
include: ">=3.24.0 <3.723.0"
56-
exclude: ">=3.363.0 <=3.377.0"
57-
mode: "max-7"
25+
include: '>=v3.723.0'
26+
mode: 'max-7'
5827
commands:
5928
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-sqs.test.ts
60-
- node: "14"
61-
versions:
62-
include: ">=3.24.0 <3.567.0"
63-
exclude: ">=3.363.0 <=3.377.0"
64-
mode: "max-7"
65-
commands:
66-
- mocha --require '@opentelemetry/contrib-test-utils' test/aws-sdk-v3-sqs.test.ts
67-

0 commit comments

Comments
 (0)