fix: http.response_content_length does not get populated when ignoreNetworkEvents is set to true (#2880)

Author: howardyoo

plugins/web/opentelemetry-instrumentation-document-load/src/instrumentation.ts

@@ -117,9 +117,11 @@ export class DocumentLoadInstrumentation extends InstrumentationBase<DocumentLoa
         if (fetchSpan) {
           fetchSpan.setAttribute(SEMATTRS_HTTP_URL, location.href);
           context.with(trace.setSpan(context.active(), fetchSpan), () => {
-            if (!this.getConfig().ignoreNetworkEvents) {
-              addSpanNetworkEvents(fetchSpan, entries);
-            }
+            addSpanNetworkEvents(
+              fetchSpan,
+              entries,
+              this.getConfig().ignoreNetworkEvents
+            );
             this._addCustomAttributesOnSpan(
               fetchSpan,
               this.getConfig().applyCustomAttributesOnSpan?.documentFetch
@@ -205,9 +207,11 @@ export class DocumentLoadInstrumentation extends InstrumentationBase<DocumentLoa
     );
     if (span) {
       span.setAttribute(SEMATTRS_HTTP_URL, resource.name);
-      if (!this.getConfig().ignoreNetworkEvents) {
-        addSpanNetworkEvents(span, resource);
-      }
+      addSpanNetworkEvents(
+        span,
+        resource,
+        this.getConfig().ignoreNetworkEvents
+      );
       this._addCustomAttributesOnResourceSpan(
         span,
         resource,

plugins/web/opentelemetry-instrumentation-document-load/test/documentLoad.test.ts

@@ -834,6 +834,27 @@ describe('DocumentLoad Instrumentation', () => {
         done();
       });
     });
+
+    it('should have http.response_content_length attribute even if ignoreNetworkEvents is true', done => {
+      plugin = new DocumentLoadInstrumentation({
+        enabled: false,
+        ignoreNetworkEvents: true,
+      });
+      plugin.enable();
+
+      setTimeout(() => {
+        const spans = exporter.getFinishedSpans();
+        const resourceSpan = spans.find(
+          s => s.name === 'resourceFetch'
+        ) as ReadableSpan;
+        assert.isOk(resourceSpan, 'resourceFetch span should exist');
+        assert.exists(
+          resourceSpan.attributes[SEMATTRS_HTTP_RESPONSE_CONTENT_LENGTH],
+          'http.response_content_length attribute should exist'
+        );
+        done();
+      });
+    });
   });
 });