fix(*): Migrate away from deprecated addSpanProcessor in tests (#2659)

Author: chancancode

plugins/node/instrumentation-cucumber/test/cucumber.test.ts

@@ -53,14 +53,14 @@ import {
 import { PassThrough } from 'stream';
 
 describe('CucumberInstrumentation', () => {
+  const memoryExporter = new InMemorySpanExporter();
+  const spanProcessor = new SimpleSpanProcessor(memoryExporter);
   const provider = new NodeTracerProvider({
     resource: new Resource({
       [SEMRESATTRS_SERVICE_NAME]: 'CucumberInstrumentation',
     }),
+    spanProcessors: [spanProcessor],
   });
-  const memoryExporter = new InMemorySpanExporter();
-  const spanProcessor = new SimpleSpanProcessor(memoryExporter);
-  provider.addSpanProcessor(spanProcessor);
   const contextManager = new AsyncHooksContextManager().enable();
 
   before(() => {

plugins/node/instrumentation-dataloader/test/dataloader.test.ts

@@ -37,12 +37,13 @@ describe('DataloaderInstrumentation', () => {
   let contextManager: AsyncHooksContextManager;
 
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
   const tracer = provider.getTracer('default');
 
   instrumentation.setTracerProvider(provider);
   extraInstrumentation.setTracerProvider(provider);
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
 
   beforeEach(async () => {
     instrumentation.enable();

plugins/node/instrumentation-fs/test/fs.test.ts

@@ -58,10 +58,11 @@ const pluginConfig = {
   createHook,
   endHook,
 };
-const provider = new BasicTracerProvider();
-const tracer = provider.getTracer('default');
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
+const tracer = provider.getTracer('default');
 
 describe('fs instrumentation', () => {
   let contextManager: AsyncHooksContextManager;

plugins/node/instrumentation-fs/test/fsHooks.test.ts

@@ -37,9 +37,10 @@ const pluginConfig = {
   endHook,
 };
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const assertNotHookError = (err?: Error | null) => {
   assert.ok(

plugins/node/instrumentation-fs/test/fsPromises.test.ts

@@ -37,10 +37,11 @@ const endHook = <EndHook>sinon.spy((fnName, { args, span }) => {
 const pluginConfig = {
   endHook,
 };
-const provider = new BasicTracerProvider();
-const tracer = provider.getTracer('default');
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
+const tracer = provider.getTracer('default');
 
 describe('fs/promises instrumentation', () => {
   let contextManager: AsyncHooksContextManager;

plugins/node/instrumentation-fs/test/fsPromisesHooks.test.ts

@@ -37,9 +37,10 @@ const pluginConfig = {
   endHook,
 };
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const assertNotHookError = (err?: Error | null) => {
   assert.ok(

plugins/node/instrumentation-fs/test/parent.test.ts

@@ -25,9 +25,10 @@ import type { FsInstrumentationConfig } from '../src/types';
 import * as api from '@opentelemetry/api';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 
-const provider = new BasicTracerProvider();
 const memoryExporter = new InMemorySpanExporter();
-provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+const provider = new BasicTracerProvider({
+  spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+});
 
 const tracer = provider.getTracer('default');
 

plugins/node/instrumentation-tedious/test/instrumentation.test.ts

@@ -89,10 +89,12 @@ describe('tedious', () => {
   let tedious: any;
   let contextManager: AsyncHooksContextManager;
   let connection: Connection;
-  const provider = new BasicTracerProvider();
+  const memoryExporter = new InMemorySpanExporter();
+  const provider = new BasicTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
   const shouldTest = process.env.RUN_MSSQL_TESTS; // For CI: assumes local db is already available
   const shouldTestLocally = process.env.RUN_MSSQL_TESTS_LOCAL; // For local: spins up local db via docker
-  const memoryExporter = new InMemorySpanExporter();
 
   before(function (done) {
     if (!(shouldTest || shouldTestLocally) || incompatVersions) {
@@ -101,7 +103,6 @@ describe('tedious', () => {
       this.test!.parent!.pending = true;
       this.skip();
     }
-    provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
     if (shouldTestLocally) {
       testUtils.startDocker('mssql');
       // wait 15 seconds for docker container to start

plugins/node/instrumentation-undici/test/fetch.test.ts

@@ -42,8 +42,9 @@ describe('UndiciInstrumentation `fetch` tests', function () {
   const hostname = 'localhost';
   const mockServer = new MockServer();
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
 
   before(function (done) {
     // Do not test if the `fetch` global API is not available

plugins/node/instrumentation-undici/test/undici.test.ts

@@ -68,8 +68,9 @@ describe('UndiciInstrumentation `undici` tests', function () {
   const hostname = 'localhost';
   const mockServer = new MockServer();
   const memoryExporter = new InMemorySpanExporter();
-  const provider = new NodeTracerProvider();
-  provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
+  const provider = new NodeTracerProvider({
+    spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
+  });
 
   before(function (done) {
     // Load `undici`. It may fail if nodejs version is <18 because the module uses