Skip to content

Commit efc2c8d

Browse files
authored
chore(lint): disable markdownlint MD060/table-column-style rule (#3271)
1 parent 1102cfa commit efc2c8d

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

.markdownlint-cli2.jsonc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
// MD004/ul-style. We prefer dash, but generated CHANGELOG.md files use
1010
// asterisk. The default "consistent" is a good compromise.
1111
"MD004": { "style": "consistent" },
12-
"MD012": false // no-multiple-blanks; disabled because common in CHANGELOG.md files
12+
// MD012/no-multiple-blanks: disabled because common in CHANGELOG.md files
13+
"MD012": false,
14+
// MD060/table-column-style: Disabled because a common case is a last column with longer prose. The current "aligned" style results is large trailing padding in the last column which makes reviews more difficult. TODO: re-evaluate after https://github.com/DavidAnson/markdownlint/issues/1818
15+
"MD060": false
1316
},
1417
"gitignore": true,
1518
"noBanner": true,

packages/instrumentation-ioredis/README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ registerInstrumentations({
4646

4747
IORedis instrumentation has few options available to choose from. You can set the following:
4848

49-
| Options | Type | Description |
50-
| ----------------------- | ------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------- |
51-
| `dbStatementSerializer` | `DbStatementSerializer` | IORedis instrumentation will serialize db.statement using the specified function. |
49+
| Options | Type | Description |
50+
| ----------------------- | ------------------------------------------------- | ----------- |
51+
| `dbStatementSerializer` | `DbStatementSerializer` | IORedis instrumentation will serialize db.statement using the specified function. |
5252
| `requestHook` | `RedisRequestCustomAttributeFunction` (function) | Function for adding custom attributes on db request. Receives params: `span, { moduleVersion, cmdName, cmdArgs }` |
53-
| `responseHook` | `RedisResponseCustomAttributeFunction` (function) | Function for adding custom attributes on db response |
54-
| `requireParentSpan` | `boolean` | Require parent to create ioredis span, default when unset is true |
53+
| `responseHook` | `RedisResponseCustomAttributeFunction` (function) | Function for adding custom attributes on db response |
54+
| `requireParentSpan` | `boolean` | Require parent to create ioredis span, default when unset is true |
5555

5656
#### Custom db.statement Serializer
5757

@@ -113,13 +113,13 @@ See [the HTTP migration guide](https://opentelemetry.io/docs/specs/semconv/non-n
113113

114114
Attributes collected:
115115

116-
| Old semconv | Stable semconv | Description |
117-
| ---------------------- | ---------------- | ---------------------------------- |
118-
| `db.connection_string` | Removed | |
119-
| `db.system` | `db.system.name` | 'redis' |
116+
| Old semconv | Stable semconv | Description |
117+
| ---------------------- | ---------------- | ----------- |
118+
| `db.connection_string` | Removed | |
119+
| `db.system` | `db.system.name` | 'redis' |
120120
| `db.statement` | `db.query.text` | The database query being executed. |
121-
| `net.peer.port` | `server.port` | Remote port number. |
122-
| `net.peer.name` | `server.address` | Remote hostname or similar. |
121+
| `net.peer.port` | `server.port` | Remote port number. |
122+
| `net.peer.name` | `server.address` | Remote hostname or similar. |
123123

124124

125125
## Useful links

0 commit comments

Comments
 (0)