Skip to content

Commit f1d20da

Browse files
committed
fix usage of old SKIP_TEST_IF_OLD_NODE_DISABLE envvar to SKIP_TEST_IF_DISABLE
Previous name was from an earlier rev of this PR. I've verified that SKIP_TEST_IF_DISABLE usage in .tav.yml works as expected.
1 parent 2d0d368 commit f1d20da

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Note: tests must set `SKIP_TEST_IF_DISABLE=true` to override usage of
2-
# `mocha --require '../../../scripts/skip-test-if-old-node.js' ...`.
2+
# `mocha --require '../../../scripts/skip-test-if.js' ...`.
33

44
"aws-sdk":
55
env:

scripts/skip-test-if.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,26 +27,26 @@
2727
* where `SKIP_TEST_IF_NODE_OLDER_THAN` indicates the minimum Node.js major
2828
* version.
2929
*
30-
* 2. ".tav.yml" blocks should set SKIP_TEST_IF_OLD_NODE_DISABLE=true to
30+
* 2. ".tav.yml" blocks should set SKIP_TEST_IF_DISABLE=true to
3131
* disable the skipping. Via this in each test block:
3232
* env:
3333
* - SKIP_TEST_IF_DISABLE=true
3434
*/
3535

3636
function skipTestIf() {
37-
if (process.env.SKIP_TEST_IF_OLD_NODE_DISABLE) {
37+
if (process.env.SKIP_TEST_IF_DISABLE) {
3838
return;
3939
}
4040

4141
const minNodeMajor = process.env.SKIP_TEST_IF_NODE_OLDER_THAN ?? Number(process.env.SKIP_TEST_IF_NODE_OLDER_THAN);
4242
if (!minNodeMajor || isNaN(minNodeMajor)) {
43-
console.warn('exit-if-old-node warning: set a minimum Node.js major version via SKIP_TEST_IF_NODE_OLDER_THAN=<num>');
43+
console.warn('skip-test-if warning: set a minimum Node.js major version via SKIP_TEST_IF_NODE_OLDER_THAN=<num>');
4444
return;
4545
}
4646

4747
const nodeMajor = Number(process.versions.node.split('.')[0]);
4848
if (nodeMajor < minNodeMajor) {
49-
process.stderr.write(`skip-test-if-old-node: skipping tests on old Node.js (${nodeMajor} < ${minNodeMajor})\n`);
49+
process.stderr.write(`skip-test-if: skipping tests on old Node.js (${nodeMajor} < ${minNodeMajor})\n`);
5050
// "Skip" tests by exiting the process. Mocha is all in one process.
5151
process.exit(0);
5252
}

0 commit comments

Comments
 (0)