Skip to content

Commit f42472e

Browse files
committed
instr-aws-sdk
1 parent 0809b07 commit f42472e

File tree

4 files changed

+158
-17
lines changed

4 files changed

+158
-17
lines changed

package-lock.json

Lines changed: 148 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

plugins/node/opentelemetry-instrumentation-aws-sdk/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
"@opentelemetry/api": "^1.3.0"
4545
},
4646
"dependencies": {
47-
"@opentelemetry/core": "^1.8.0",
48-
"@opentelemetry/instrumentation": "^0.57.2",
47+
"@opentelemetry/core": "^2.0.0-dev.0",
48+
"@opentelemetry/instrumentation": "^0.200.0-dev.0",
4949
"@opentelemetry/propagation-utils": "^0.30.16",
5050
"@opentelemetry/semantic-conventions": "^1.27.0"
5151
},
@@ -59,7 +59,7 @@
5959
"@aws-sdk/types": "3.78.0",
6060
"@opentelemetry/api": "^1.3.0",
6161
"@opentelemetry/contrib-test-utils": "^0.45.1",
62-
"@opentelemetry/sdk-trace-base": "^1.8.0",
62+
"@opentelemetry/sdk-trace-base": "^2.0.0-dev.0",
6363
"@smithy/node-http-handler": "2.4.0",
6464
"@types/mocha": "10.0.10",
6565
"@types/node": "18.18.14",
@@ -75,6 +75,6 @@
7575
"typescript": "4.4.4"
7676
},
7777
"engines": {
78-
"node": ">=14"
78+
"node": "^18.19.0 || >=20.6.0"
7979
}
8080
}

plugins/node/opentelemetry-instrumentation-aws-sdk/test/aws-sdk-v2.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ describe('instrumentation-aws-sdk-v2', () => {
6666

6767
const getAwsSpans = (): ReadableSpan[] => {
6868
return getTestSpans().filter(s =>
69-
s.instrumentationLibrary.name.includes('aws-sdk')
69+
s.instrumentationScope.name.includes('aws-sdk')
7070
);
7171
};
7272

plugins/node/opentelemetry-instrumentation-aws-sdk/test/sqs.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe('SQS', () => {
9797
expect(awsReceiveSpan.length).toBe(1);
9898
const internalSpan = spans.filter(s => s.kind === SpanKind.INTERNAL);
9999
expect(internalSpan.length).toBe(1);
100-
expect(internalSpan[0].parentSpanId).toStrictEqual(
100+
expect(internalSpan[0].parentSpanContext?.spanId).toStrictEqual(
101101
awsReceiveSpan[0].spanContext().spanId
102102
);
103103
};
@@ -200,20 +200,20 @@ describe('SQS', () => {
200200
MESSAGINGOPERATIONVALUES_PROCESS
201201
);
202202
expect(processSpans.length).toBe(2);
203-
expect(processSpans[0].parentSpanId).toStrictEqual(
203+
expect(processSpans[0].parentSpanContext?.spanId).toStrictEqual(
204204
awsReceiveSpan[0].spanContext().spanId
205205
);
206-
expect(processSpans[1].parentSpanId).toStrictEqual(
206+
expect(processSpans[1].parentSpanContext?.spanId).toStrictEqual(
207207
awsReceiveSpan[0].spanContext().spanId
208208
);
209209

210210
const processChildSpans = spans.filter(s => s.kind === SpanKind.INTERNAL);
211211
expect(processChildSpans.length).toBe(2 * numChildPerProcessSpan);
212212
for (let i = 0; i < numChildPerProcessSpan; i++) {
213-
expect(processChildSpans[2 * i + 0].parentSpanId).toStrictEqual(
213+
expect(processChildSpans[2 * i + 0].parentSpanContext?.spanId).toStrictEqual(
214214
processSpans[0].spanContext().spanId
215215
);
216-
expect(processChildSpans[2 * i + 1].parentSpanId).toStrictEqual(
216+
expect(processChildSpans[2 * i + 1].parentSpanContext?.spanId).toStrictEqual(
217217
processSpans[1].spanContext().spanId
218218
);
219219
}

0 commit comments

Comments
 (0)