Skip to content

Commit fa12583

Browse files
committed
drop the skip-test-if support added in #2723 because it is no longer necessary
With JS SDK 2.0 the min supported Node.js is v18, which suffices for the latest instrumented deps currently being used.
1 parent bde108c commit fa12583

File tree

3 files changed

+1
-64
lines changed

3 files changed

+1
-64
lines changed

plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
1-
# Note: tests must set `SKIP_TEST_IF_DISABLE=true` to override usage of
2-
# `mocha --require '../../../scripts/skip-test-if.js' ...` if calling `npm test`.
3-
41
# Versions [3.363.0, 3.377.0] of all @aws-sdk/client-* were bad releases. See:
52
# - https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2464#issuecomment-2403652552
63
# - https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719
74

8-
# node version support in JS SDK v3:
9-
# - 14.x dropped in v3.567.0 https://github.com/aws/aws-sdk-js-v3/pull/6034
10-
# - 16.x dropped in v3.723.0 https://github.com/aws/aws-sdk-js-v3/pull/6775
11-
125
"@aws-sdk/client-bedrock-runtime":
136
env:
147
- SKIP_TEST_IF_DISABLE=true

plugins/node/opentelemetry-instrumentation-aws-sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"prewatch": "npm run precompile",
3636
"prepublishOnly": "npm run compile",
3737
"tdd": "npm run test -- --watch-extensions ts --watch",
38-
"test": "SKIP_TEST_IF_NODE_OLDER_THAN=18 nyc mocha --require '../../../scripts/skip-test-if.js' --require '@opentelemetry/contrib-test-utils' 'test/**/*.test.ts'",
38+
"test": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/**/*.test.ts'",
3939
"test-all-versions": "tav",
4040
"version:update": "node ../../../scripts/version-update.js",
4141
"watch": "tsc -w"

scripts/skip-test-if.js

Lines changed: 0 additions & 56 deletions
This file was deleted.

0 commit comments

Comments
 (0)