Remove attached cache attributes.

Author: onurtemizkan

plugins/node/instrumentation-dataloader/src/instrumentation.ts

@@ -186,13 +186,6 @@ export class DataloaderInstrumentation extends InstrumentationBase<DataloaderIns
         const result = original
           .call(this, ...args)
           .then(value => {
-            span.setAttribute('cache.key', [args[0]]);
-            span.setAttribute('cache.hit', value !== undefined);
-            span.setAttribute(
-              'cache.item_size',
-              value ? JSON.stringify(value).length : 0
-            );
-
             span.end();
             return value;
           })
@@ -251,19 +244,6 @@ export class DataloaderInstrumentation extends InstrumentationBase<DataloaderIns
         // .loadMany never rejects, as errors from internal .load
         // calls are caught by dataloader lib
         return original.call(this, ...args).then(value => {
-          span.setAttribute('cache.key', Array.from(args[0]));
-          span.setAttribute(
-            'cache.hit',
-            value.every((v: unknown) => v !== undefined)
-          );
-          span.setAttribute(
-            'cache.item_size',
-            value.reduce(
-              (acc: number, v: unknown) => acc + JSON.stringify(v).length,
-              0
-            )
-          );
-
           span.end();
           return value;
         });
@@ -301,12 +281,6 @@ export class DataloaderInstrumentation extends InstrumentationBase<DataloaderIns
         return original.call(this, ...args);
       });
 
-      span.setAttribute('cache.key', [args[0]]);
-      span.setAttribute(
-        'cache.item_size',
-        args[1] ? JSON.stringify(args[1]).length : 0
-      );
-
       span.end();
 
       return ret;
@@ -340,8 +314,6 @@ export class DataloaderInstrumentation extends InstrumentationBase<DataloaderIns
       );
 
       const ret = context.with(trace.setSpan(parent, span), () => {
-        span.setAttribute('cache.key', [args[0]]);
-
         return original.call(this, ...args);
       });
 

plugins/node/instrumentation-dataloader/test/dataloader.test.ts

@@ -184,38 +184,6 @@ describe('DataloaderInstrumentation', () => {
         assert.strictEqual(batchSpan.name, 'dataloader.batch test-name');
       }
     });
-
-    it('correctly sets cache.key, cache.hit and cache.item_size attributes when data is available', async () => {
-      assert.strictEqual(await dataloader.load('test'), getMd5HashFromIdx(0));
-
-      // We should have exactly two spans (one for .load and one for the batch)
-      assert.strictEqual(memoryExporter.getFinishedSpans().length, 2);
-      const [_batchSpan, loadSpan] = memoryExporter.getFinishedSpans();
-
-      assert.deepStrictEqual(loadSpan.attributes, {
-        'cache.key': ['test'],
-        'cache.hit': true,
-        'cache.item_size': 34,
-      });
-    });
-
-    it('correctly sets cache.key, cache.hit and cache.item_size attributes when data is not available', async () => {
-      const namedDataloader = new Dataloader(async keys => {
-        return keys.map(() => undefined);
-      });
-
-      assert.strictEqual(await namedDataloader.load('unavailable'), undefined);
-
-      // We should have exactly two spans (one for .load and one for the batch)
-      assert.strictEqual(memoryExporter.getFinishedSpans().length, 2);
-      const [_batchSpan, loadSpan] = memoryExporter.getFinishedSpans();
-
-      assert.deepStrictEqual(loadSpan.attributes, {
-        'cache.key': ['unavailable'],
-        'cache.hit': false,
-        'cache.item_size': 0,
-      });
-    });
   });
 
   describe('loadMany', () => {
@@ -429,18 +397,6 @@ describe('DataloaderInstrumentation', () => {
         assert.strictEqual(clearSpan.name, 'dataloader.clear test-name');
       }
     });
-
-    it('correctly sets attributes for clearing', async () => {
-      dataloader.clear('test');
-
-      // We should have exactly one span
-      assert.strictEqual(memoryExporter.getFinishedSpans().length, 1);
-      const [clearSpan] = memoryExporter.getFinishedSpans();
-
-      assert.deepStrictEqual(clearSpan.attributes, {
-        'cache.key': ['test'],
-      });
-    });
   });
 
   describe('clearAll', () => {
@@ -593,19 +549,6 @@ describe('DataloaderInstrumentation', () => {
       assert.strictEqual(primeSpan1.name, 'dataloader.prime');
       assert.strictEqual(primeSpan2.name, 'dataloader.prime');
     });
-
-    it('correctly creates attributes for priming', async () => {
-      dataloader.prime('test', '1');
-
-      // We should have exactly one span
-      assert.strictEqual(memoryExporter.getFinishedSpans().length, 1);
-      const [primeSpan] = memoryExporter.getFinishedSpans();
-
-      assert.deepStrictEqual(primeSpan.attributes, {
-        'cache.key': ['test'],
-        'cache.item_size': 3,
-      });
-    });
   });
 
   it('should not create anything if disabled', async () => {