chore: sha and branch are null in push event

Author: david-luna

.github/workflows/test.yml

@@ -286,5 +286,5 @@ jobs:
       - name: Merge coverage (Delta)
         run: npm run test-merge-coverage:ci:affected
       - name: Report Coverage with Flags
-        run: node ./scripts/codecov-upload-flags.mjs ${{ github.sha }} ${{ github.event.pull_request.head.label }}
+        run: node ./scripts/codecov-upload-flags.mjs ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.head.label }}
 

scripts/codecov-upload-flags.mjs

@@ -9,15 +9,6 @@ import path from 'path';
 const commitSha = process.argv[2];
 const branchName = process.argv[3];
 
-if (typeof commitSha !== 'string') {
-  console.log('Error: Commit sha missing. Exiting');
-  process.exit(-1);
-}
-if (typeof branchName !== 'string') {
-  console.log('Warn: Branch name missing.');
-}
-
-
 const readPkg = (dir) => JSON.parse(readFileSync(path.join(dir, 'package.json'), 'utf8'));
 const pkgInfo = readPkg('.');
 const pkgFiles = pkgInfo.workspaces.map((exp) => globSync(path.join(exp, 'package.json')));
@@ -39,16 +30,19 @@ const pkgsWithFlag = pkgFiles.flat().map((f) => {
     // we don't need xcrun or pycoverage plugins
     '--plugin gcov',
     '--gcov-executable gcov',
-    '--sha', commitSha,
     '--file', report,
     '--flag', flag,
     // limit any scan to the pacakge folder
     '--dir', path,
   ];
 
-  if (branchName) {
+  if (typeof commitSha === 'string') {
+    command.push('--sha', commitSha);
+  }
+  if (typeof branchName === 'string') {
     command.push('--branch', branchName);
   }
+
   return { name, flag, path, report, command: command.join(' ') };
 });