more old rules, disable new node rules

Author: overbalance

eslint.config.mjs

@@ -1,10 +1,9 @@
 /* eslint-disable license-header/header */
-/* eslint-disable n/no-unpublished-import */
 import eslint from '@eslint/js';
 import tseslint from 'typescript-eslint';
 import globals from 'globals';
-import nodePlugin from 'eslint-plugin-n';
 import licenseHeaderPlugin from 'eslint-plugin-license-header';
+import nodePlugin from 'eslint-plugin-n';
 
 const license = [
   '/*',
@@ -34,16 +33,14 @@ const baseConfig = tseslint.config(
     ],
   },
   {
-    files: ['**/*.{js,ts,mjs}'],
+    files: ['**/*.{js,ts,mjs}', '*.{js,ts,mjs}'],
     plugins: {
       'license-header': licenseHeaderPlugin,
-      n: nodePlugin,
-      '@typescript-eslint': tseslint.plugin,
+      node: nodePlugin,
     },
     extends: [
       eslint.configs.recommended,
-      tseslint.configs.recommended,
-      nodePlugin.configs['flat/recommended'],
+      // nodePlugin.configs['flat/recommended'],
     ],
     languageOptions: {
       ecmaVersion: 2022,
@@ -57,27 +54,59 @@ const baseConfig = tseslint.config(
       },
     },
     rules: {
+      // old rules
       quotes: ['error', 'single', { avoidEscape: true }],
       eqeqeq: ['error', 'smart'],
       'prefer-rest-params': 'off',
-      'n/no-deprecated-api': ['warn'],
       'license-header/header': ['error', license],
+
+      // new rules
+      'no-unused-vars': 'warn',
+      'node/no-deprecated-api': 'warn',
     },
   },
 
   // TypeScript strict rules
   {
     files: ['**/*.ts'],
-    // extends: [...tseslint.configs.strictTypeChecked],
-    extends: [...tseslint.configs.recommendedTypeChecked],
+    plugins: {
+      '@typescript-eslint': tseslint.plugin,
+    },
+    // turn on when we can check types
+    // extends: [...tseslint.configs.recommendedTypeChecked],
+    extends: [...tseslint.configs.recommended],
     languageOptions: {
       parser: tseslint.parser,
       parserOptions: {
         project: true,
       },
     },
     rules: {
-      '@typescript-eslint/no-var-requires': 'off',
+      // 'node/no-missing-import': 'off',
+
+      // things that should be repaired
+      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-require-imports': 'warn',
+      '@typescript-eslint/no-unsafe-function-type': 'warn',
+      '@typescript-eslint/no-empty-object-type': 'warn',
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        { argsIgnorePattern: '^_' },
+      ],
+
+      // old rules
+      // this is a replacement for the deprecated ban-types rules
+      '@typescript-eslint/no-restricted-types': [
+        'warn',
+        {
+          types: {
+            Function: 'fix',
+          },
+        },
+      ],
+      // TODO: fix inheritance
+      '@typescript-eslint/no-floating-promises': 'error',
+      '@typescript-eslint/no-this-alias': 'off',
       '@typescript-eslint/naming-convention': [
         'error',
         {
@@ -87,11 +116,18 @@ const baseConfig = tseslint.config(
           leadingUnderscore: 'require',
         },
       ],
-      'n/no-missing-import': 'off',
+      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/no-inferrable-types': [
+        'error',
+        { ignoreProperties: true },
+      ],
+      '@typescript-eslint/no-empty-function': ['off'],
+      '@typescript-eslint/no-shadow': ['warn'],
+      'prefer-rest-params': 'off',
     },
   },
 
-  // Test files relaxed rules
+  // Test files have relaxed rules
   {
     files: ['**/test/**/*.ts', '**/*.test.ts'],
     rules: {