suggested changes, lint fix

Author: Abinet18

examples/web/package.json

@@ -5,8 +5,6 @@
   "description": "Example of using web plugins in browser",
   "main": "index.js",
   "scripts": {
-    "lint": "eslint . --ext=ts,js,mjs",
-    "lint:fix": "eslint . --ext=ts,js,mjs --fix",
     "docker:start": "cd ./docker && docker-compose down && docker-compose up",
     "docker:startd": "cd ./docker && docker-compose down && docker-compose up -d",
     "start": "webpack serve --mode development --progress --port 8090 --config webpack.config.js --hot --host 0.0.0.0"

packages/instrumentation-browser-navigation/.eslintignore

@@ -1,11 +1,11 @@
-/*!
+/*
  * Copyright The OpenTelemetry Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *      https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,

packages/instrumentation-browser-navigation/.eslintrc.js

@@ -9,9 +9,6 @@
   "repository": "open-telemetry/opentelemetry-js-contrib",
   "scripts": {
     "clean": "tsc --build --clean tsconfig.json tsconfig.esm.json tsconfig.esnext.json",
-    "lint": "eslint  --ext .ts",
-    "lint:fix": "eslint  --ext .ts --fix",
-    "lint:readme": "node ../../scripts/lint-readme.js",
     "prewatch": "npm run version:update",
     "version:update": "node ../../scripts/version-update.js",
     "compile": "tsc --build tsconfig.json tsconfig.esm.json tsconfig.esnext.json",

packages/instrumentation-browser-navigation/karma.conf.js

@@ -171,7 +171,9 @@ export class BrowserNavigationInstrumentation extends InstrumentationBase<Browse
       try {
         const navigationApi = (window as any).navigation as EventTarget;
         navigationApi?.removeEventListener?.('navigate', this._onNavigateHandler);
-      } catch {}
+      } catch {
+        // Ignore errors when removing Navigation API listeners
+      }
       this._onNavigateHandler = undefined;
     }
   }
@@ -314,6 +316,11 @@ export class BrowserNavigationInstrumentation extends InstrumentationBase<Browse
    * - Preserves fragment when available
    */
   private _sanitizeUrl(url: string): string {
+    const sensitiveParams = [
+      'password', 'passwd', 'secret', 'api_key', 'apikey', 'auth', 'authorization',
+      'token', 'access_token', 'refresh_token', 'jwt', 'session', 'sessionid',
+      'key', 'private_key', 'client_secret', 'client_id', 'signature', 'hash'
+    ];
     try {
       const urlObj = new URL(url);
 
@@ -324,11 +331,7 @@ export class BrowserNavigationInstrumentation extends InstrumentationBase<Browse
       }
 
       // Redact sensitive query parameters
-      const sensitiveParams = [
-        'password', 'passwd', 'secret', 'api_key', 'apikey', 'auth', 'authorization',
-        'token', 'access_token', 'refresh_token', 'jwt', 'session', 'sessionid',
-        'key', 'private_key', 'client_secret', 'client_id', 'signature', 'hash'
-      ];
+     
 
       for (const param of sensitiveParams) {
         if (urlObj.searchParams.has(param)) {
@@ -341,13 +344,6 @@ export class BrowserNavigationInstrumentation extends InstrumentationBase<Browse
       // If URL parsing fails, redact credentials and sensitive query parameters
       let sanitized = url.replace(/\/\/[^:]+:[^@]+@/, '//REDACTED:REDACTED@');
 
-      // Redact sensitive query parameters using regex
-      const sensitiveParams = [
-        'password', 'passwd', 'secret', 'api_key', 'apikey', 'auth', 'authorization',
-        'token', 'access_token', 'refresh_token', 'jwt', 'session', 'sessionid',
-        'key', 'private_key', 'client_secret', 'client_id', 'signature', 'hash'
-      ];
-      
       for (const param of sensitiveParams) {
         // Match param=value or param%3Dvalue (URL encoded)
         const regex = new RegExp(`([?&]${param}(?:%3D|=))[^&]*`, 'gi');

packages/instrumentation-browser-navigation/package.json

@@ -391,7 +391,7 @@ describe('Browser Navigation Instrumentation', () => {
             }
           }, 50);
         }
-      } catch (error) {
+      } catch (_error) {
         // Fallback if Navigation API methods fail
         console.log('Navigation API methods not fully supported, using fallback');
         history.pushState({}, '', '?test=fallback');
@@ -484,7 +484,7 @@ describe('Browser Navigation Instrumentation', () => {
             }
           }, 50);
         }
-      } catch (error) {
+      } catch (_error) {
         // Fallback to traditional hash change
         location.hash = '#section1';
         setTimeout(() => {

packages/instrumentation-browser-navigation/src/instrumentation.ts

@@ -1,11 +1,11 @@
-/*!
+/*
  * Copyright The OpenTelemetry Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *      https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,