Skip to content

Commit feb7bcc

Browse files
committed
remove unnecessary catch blocks from unit tests.
1 parent 485e4eb commit feb7bcc

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

packages/instrumentation-aws-sdk/test/secretsmanager.test.ts

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,11 @@ describe('SecretsManager', () => {
4949
it('should generate secret arn attribute only if secretId is an valid ARN', async () => {
5050
nock(`https://secretsmanager.${region}.amazonaws.com/`)
5151
.post('/')
52-
.reply(200, 'null');
52+
.reply(200, '{}');
5353

54-
await secretsManager
55-
.describeSecret({
56-
SecretId: secretId,
57-
})
58-
.catch((err: any) => {});
54+
await secretsManager.describeSecret({
55+
SecretId: secretId,
56+
});
5957

6058
const testSpans: ReadableSpan[] = getTestSpans();
6159
const getDescribeSecretSpans: ReadableSpan[] = testSpans.filter(
@@ -94,13 +92,9 @@ describe('SecretsManager', () => {
9492
Name: 'testId',
9593
});
9694

97-
await secretsManager
98-
.getSecretValue({
99-
SecretId: 'testSecret',
100-
})
101-
.catch((err: any) => {
102-
console.log(err);
103-
});
95+
await secretsManager.getSecretValue({
96+
SecretId: 'testSecret',
97+
});
10498

10599
const testSpans: ReadableSpan[] = getTestSpans();
106100
const getSecretValueSpans: ReadableSpan[] = testSpans.filter(

0 commit comments

Comments
 (0)