Apply suggestions from code review

Co-authored-by: Trent Mick <[email protected]>

Author: deejay1

plugins/node/opentelemetry-instrumentation-knex/README.md

@@ -73,7 +73,7 @@ When upgrading to the new semantic conventions, it is recommended to do so in th
 
 This will cause both the old and new semantic conventions to be emitted during the transition period.
 
-### ### Legacy Behavior (default)
+### Legacy Behavior (default)
 
 Enabled when `OTEL_SEMCONV_STABILITY_OPT_IN` contains `database/dup` or DOES NOT CONTAIN `database`.
 

plugins/node/opentelemetry-instrumentation-knex/src/instrumentation.ts

@@ -171,7 +171,7 @@ export class KnexInstrumentation extends InstrumentationBase<KnexInstrumentation
         const transport =
           config?.connection?.filename === ':memory:' ? 'inproc' : undefined;
 
-        if ((semConv & SemconvStability.OLD) === SemconvStability.OLD) {
+        if (semConv & SemconvStability.OLD) {
           Object.assign(attributes, {
             [SEMATTRS_DB_SYSTEM]: mapSystem(config.client),
             [SEMATTRS_DB_SQL_TABLE]: table,
@@ -183,7 +183,7 @@ export class KnexInstrumentation extends InstrumentationBase<KnexInstrumentation
             [SEMATTRS_NET_TRANSPORT]: transport,
           });
         }
-        if ((semConv & SemconvStability.STABLE) === SemconvStability.STABLE) {
+        if (semConv & SemconvStability.STABLE) {
           Object.assign(attributes, {
             [ATTR_DB_SYSTEM_NAME]: mapSystem(config.client),
             [ATTR_DB_COLLECTION_NAME]: table,