-
Notifications
You must be signed in to change notification settings - Fork 619
Closed
Labels
needs:code-contributionThis feature/bug is ready to implementThis feature/bug is ready to implementtype:feature-trackingA feature with sub-issues that need to be addressedA feature with sub-issues that need to be addressedup-for-grabsGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainers
Description
A lot of the tests in this repository require some dependencies to run (postgres, mysql, redis).
By default, we skip a lot of tests since these dependencies need to be spun up manually. Usually, to run them locally an env var needs to be set that prevents these tests from being skipped. Unfortunately this is currently inconsistent across packages.
The goal of this issue is to streamline the testing setup and ensure scripts behave the same in each package, and add missing scripts if necessary:
test:docker:start- spins up one or more docker containers which are used for testing, mapping ports if necessary
test:docker:stop- stops the containers started by
test:docker:start
- stops the containers started by
test:local- sets the necessary environment variables for the test
- runs the tests
To keep review scope manageable, only work on one PR per package:
-
@opentelemetry/instrumentation-memcached -
@opentelemetry/instrumentation-cassandra -
@opentelemetry/instrumentation-mongodb -
@opentelemetry/instrumentation-mongoose -
@opentelemetry/instrumentation-mysql -
@opentelemetry/instrumentation-mysql2 -
@opentelemetry/instrumentation-tedious -
@opentelemetry/instrumentation-pg -
@opentelemetry/instrumentation-redis -
@opentelemetry/instrumentation-redis-4 -
@opentelemetry/instrumentation-amqplib
Additional task (documentation):
Once all packages have been updated:
- document how to run local tests for a package in
CONTRIBUTING.md. Since all scripts behave the same, it should be enough to mention the order of scripts to run.
Additional resources
trentm
Metadata
Metadata
Assignees
Labels
needs:code-contributionThis feature/bug is ready to implementThis feature/bug is ready to implementtype:feature-trackingA feature with sub-issues that need to be addressedA feature with sub-issues that need to be addressedup-for-grabsGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainers