Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Oct 23, 2024

  • Use range deps for @opentelemetry/* deps (with some exceptions for
    /api and /semantic-conventions). This allows
    scripts/update-otel-deps.js to be able to do its thing.
  • "propagators/propagator-aws-xray/" only needed @opentelemetry/core
    for tests

- Use range deps for `@opentelemetry/*` deps (with some exceptions for
  /api and /semantic-conventions). This allows
  scripts/update-otel-deps.js to be able to do its thing.
- "propagators/propagator-aws-xray/" only needed `@opentelemetry/core`
  for tests
@trentm trentm self-assigned this Oct 23, 2024
@trentm trentm requested a review from a team as a code owner October 23, 2024 18:35
@github-actions github-actions bot added pkg:plugin-react-load pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. pkg:propagator-aws-xray pkg:propagator-aws-xray-lambda labels Oct 23, 2024
@github-actions github-actions bot requested a review from martinkuba October 23, 2024 18:36
},
"devDependencies": {
"@opentelemetry/api": ">=1.0.0 <1.10.0",
"@opentelemetry/core": "^1.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer note: This had been ^1.0.0 before it was moved to the core repo and then back here. The only usage is for import { TraceState } from '@opentelemetry/core'; in tests.

@trentm
Copy link
Contributor Author

trentm commented Oct 23, 2024

@pichlermarc @JamieDanielson This is the change I needed before doing the "scripts/update-otel-deps.js" PR -- as discussed in the SIG today.

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (97a2956) to head (563e23f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2499   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         159      159           
  Lines        7851     7851           
  Branches     1621     1621           
=======================================
  Hits         7133     7133           
  Misses        718      718           

@github-actions
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@pichlermarc pichlermarc added the dependencies Pull requests that update a dependency file label Oct 24, 2024
@pichlermarc pichlermarc merged commit d3c8bd9 into open-telemetry:main Oct 24, 2024
20 checks passed
@trentm trentm deleted the tm-range-deps branch October 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pkg:plugin-react-load pkg:propagator-aws-xray pkg:propagator-aws-xray-lambda pkg-status:unmaintained:autoclose-scheduled pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants