-
Notifications
You must be signed in to change notification settings - Fork 620
chore(propagator-aws-xray): update npm scripts to align with other pkgs in contrib repo #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…gs in contrib repo Also drop the cross-var dep, now unused
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 159 159
Lines 7853 7853
Branches 1622 1622
=======================================
Hits 7135 7135
Misses 718 718 |
|
A little story about git clone [email protected]:open-telemetry/opentelemetry-js.git this-src-is-crazy
cd this-src-is-crazy
npm ci
npx cross-var echo hiDoes that fail with something like this? We use Turns out the author wanted to use ESM code, but unfortunately was living in 2017 when this was written (before current versions of Node.js supported ESM). "No problem," they said, "I'll use Babel to down compile to JS that the current node can run." At runtime. Everytime. "And I'll use the handy
require( "babel-register" )( {
ignore: false,
only: /src/
} );Unfortunately that means that any match for "src" in the full path is a hit -- and "src" is in the top dirname I specified above. And babel blows up on ".../this-src-is-crazy/node_modules/babel-plugin-transform-regenerator/node_modules/regenerator-transform/lib/index.js" for reasons I didn't get in to. (In my personal case, I sometimes work on a clone of opentelemetry-js.git and opentelemetry-js-contrib.git in my If the above was changed to: require( "babel-register" )( {
ignore: false,
only: /cross-var\/src\/index.js$/
} );it would be fine. I would like to just remove cross-var from our repos. |
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
Also drop the cross-var dep, now unused.