Skip to content

feat(auto-instrumentations-node): enable runtime-node #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
romancepenguin wants to merge 1 commit into from
Closed

feat(auto-instrumentations-node): enable runtime-node #2524

romancepenguin wants to merge 1 commit into from
+4 −0

Conversation

@romancepenguin
Copy link

@romancepenguin romancepenguin commented Nov 11, 2024

Which problem is this PR solving?

Short description of the changes

  • This PR adds @opentelemetry/instrumentation-runtime-node to the @opentelemetry/auto-instrumentations-node meta package

@romancepenguin romancepenguin requested a review from a team as a code owner November 11, 2024 09:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 11, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: romancepenguin / name: leejaekyu (d013655)

@romancepenguin romancepenguin force-pushed the runtime-node-auto-instrumentation branch from 441d85f to d013655 Compare November 11, 2024 11:37
@codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (5eb61d8) to head (d013655).
Report is 134 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8019    +1     
  Branches     1632     1632           
=======================================
+ Hits         7277     7278    +1     
  Misses        741      741
Files with missing lines Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.24% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ElfoLiNk
Copy link
Contributor

ElfoLiNk commented Dec 18, 2024

Hi, would be good to have this merged and released.
Thank you

@pichlermarc
Copy link
Member

pichlermarc commented Jan 15, 2025

This PR needs approval from the owner of the instrumentation, cc @d4nyll - having it in the auto-instrumentation package and enabled by default will likely mean more users, which means often means that additional maintenance effort is required.

@d4nyll
Copy link
Member

d4nyll commented Jan 15, 2025

@pichlermarc Happy to handle any additional maintenance work

@d4nyll d4nyll mentioned this pull request Jan 27, 2025
Closed
6 tasks
blumamir
blumamir approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support adding this instrumentation to the auto instrumentation package

@pichlermarc
Copy link
Member

pichlermarc commented Feb 13, 2025

@romancepenguin please resolve the conflicts, then we can merge this in 🙂

@ElfoLiNk
Copy link
Contributor

ElfoLiNk commented Mar 26, 2025

Hi @romancepenguin any news?

@ElfoLiNk ElfoLiNk mentioned this pull request Apr 10, 2025
Merged
@maryliag
Copy link
Contributor

maryliag commented Apr 14, 2025 •
edited
Loading

Solved by #2786

@maryliag maryliag closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-luna david-luna david-luna approved these changes

@maryliag maryliag maryliag approved these changes

@blumamir blumamir blumamir approved these changes

@dyladan dyladan Awaiting requested review from dyladan

@legendecas legendecas Awaiting requested review from legendecas

@pichlermarc pichlermarc Awaiting requested review from pichlermarc

Assignees

@dyladan dyladan

@legendecas legendecas

@pichlermarc pichlermarc

@blumamir blumamir

Labels

pkg:auto-instrumentations-node pkg:instrumentation-runtime-node

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@romancepenguin @ElfoLiNk @pichlermarc @d4nyll @maryliag @david-luna @blumamir @dyladan @legendecas