From cfac2d9266780af310dc4e0886602b41d25541c6 Mon Sep 17 00:00:00 2001 From: maryliag Date: Wed, 8 Jan 2025 15:04:42 -0500 Subject: [PATCH 1/2] fix unit for eventloop.utilization --- .../src/metrics/eventLoopUtilizationCollector.ts | 2 +- .../test/event_loop_utilization.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts index 321e54aa6f..97a5642708 100644 --- a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts +++ b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts @@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector { `${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`, { description: 'Event loop utilization', - unit: 's', + unit: '1', } ) .addCallback(async observableResult => { diff --git a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts index 77aaf77a9d..e434557f20 100644 --- a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts +++ b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts @@ -90,7 +90,7 @@ describe(`${ConventionalNamePrefix.NodeJs}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION} assert.strictEqual( utilizationMetric!.descriptor.unit, - 's', + '1', 'expected default unit' ); From 767ba285ee24b3b21e60da656618434331658b94 Mon Sep 17 00:00:00 2001 From: maryliag Date: Wed, 8 Jan 2025 15:04:42 -0500 Subject: [PATCH 2/2] fix unit for eventloop.utilization --- .../src/metrics/eventLoopUtilizationCollector.ts | 2 +- .../test/event_loop_utilization.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts index 321e54aa6f..97a5642708 100644 --- a/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts +++ b/plugins/node/instrumentation-runtime-node/src/metrics/eventLoopUtilizationCollector.ts @@ -38,7 +38,7 @@ export class EventLoopUtilizationCollector extends BaseCollector { `${this.namePrefix}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION}`, { description: 'Event loop utilization', - unit: 's', + unit: '1', } ) .addCallback(async observableResult => { diff --git a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts index 77aaf77a9d..e434557f20 100644 --- a/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts +++ b/plugins/node/instrumentation-runtime-node/test/event_loop_utilization.test.ts @@ -90,7 +90,7 @@ describe(`${ConventionalNamePrefix.NodeJs}.${ATTR_NODEJS_EVENT_LOOP_UTILIZATION} assert.strictEqual( utilizationMetric!.descriptor.unit, - 's', + '1', 'expected default unit' );