From a22b9e465d49530d1b9c3f22e31a58c7293871e3 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Wed, 8 Jan 2025 12:45:25 -0800 Subject: [PATCH 1/2] test(aws-sdk): drop support for Node.js 14.x --- package-lock.json | 2 +- plugins/node/opentelemetry-instrumentation-aws-sdk/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index a2d0a16715..d59a39fcf2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -37371,7 +37371,7 @@ "typescript": "4.4.4" }, "engines": { - "node": ">=14" + "node": ">=16" }, "peerDependencies": { "@opentelemetry/api": "^1.3.0" diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json index 25d7b2e8bb..89934b8515 100644 --- a/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json +++ b/plugins/node/opentelemetry-instrumentation-aws-sdk/package.json @@ -75,6 +75,6 @@ "typescript": "4.4.4" }, "engines": { - "node": ">=14" + "node": ">=16" } } From dfb0af2c541d8f06cbd1994618ebeaf354346ae9 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Wed, 8 Jan 2025 12:52:37 -0800 Subject: [PATCH 2/2] fix: update .tav.yml to remove Node.js 14.x --- .../opentelemetry-instrumentation-aws-sdk/.tav.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml b/plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml index 81c3388cf5..44b22694ba 100644 --- a/plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml +++ b/plugins/node/opentelemetry-instrumentation-aws-sdk/.tav.yml @@ -11,7 +11,6 @@ # - https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719 # node version support in JS SDK v3: -# - 14.x dropped in v3.567.0 https://github.com/aws/aws-sdk-js-v3/pull/6034 # - 16.x dropped in v3.723.0 https://github.com/aws/aws-sdk-js-v3/pull/6775 "@aws-sdk/client-s3": @@ -29,12 +28,6 @@ exclude: "3.529.0 || >=3.363.0 <=3.377.0" mode: "max-7" commands: npm run test - - node: "14" - versions: - include: "^3.6.1 && <3.567.0" - exclude: "3.529.0 || >=3.363.0 <=3.377.0" - mode: "max-7" - commands: npm run test "@aws-sdk/client-sqs": jobs: @@ -50,9 +43,3 @@ exclude: ">=3.363.0 <=3.377.0" mode: "max-7" commands: npm run test - - node: "14" - versions: - include: "^3.24.0 && <3.567.0" - exclude: ">=3.363.0 <=3.377.0" - mode: "max-7" - commands: npm run test