Skip to content

Conversation

@garysassano
Copy link
Member

Which problem is this PR solving?

All experimental attributes were moved to @opentelemetry/semantic-conventions/incubating (see README) and the naming convention was changed, so there are currently dozens of deprecation being displayed for AWS Detectors.

Short description of the changes

This PR updates all attributes for AWS Detectors to the new convention.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code changes look good, but the package.json changes I think are not needed in this PR

@garysassano garysassano requested a review from dyladan January 15, 2025 05:58
@garysassano
Copy link
Member Author

@dyladan Is it possible to review again?

@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Jan 17, 2025
@pichlermarc pichlermarc dismissed dyladan’s stale review January 17, 2025 12:22

outdated review

@pichlermarc pichlermarc merged commit f97bd70 into open-telemetry:main Jan 17, 2025
30 checks passed
@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (e9263a3) to head (29e169c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2642   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8061     8061           
  Branches     1646     1646           
=======================================
  Hits         7319     7319           
  Misses        742      742           
Files with missing lines Coverage Δ
...ctor-aws/src/detectors/AwsBeanstalkDetectorSync.ts 96.42% <ø> (ø)
...e-detector-aws/src/detectors/AwsEc2DetectorSync.ts 98.21% <ø> (ø)
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 97.11% <100.00%> (ø)
...e-detector-aws/src/detectors/AwsEksDetectorSync.ts 91.86% <100.00%> (ø)
...etector-aws/src/detectors/AwsLambdaDetectorSync.ts 100.00% <100.00%> (ø)

@dyladan dyladan mentioned this pull request Jan 17, 2025
ATTR_SERVICE_INSTANCE_ID,
CLOUD_PROVIDER_VALUE_AWS,
CLOUD_PLATFORM_VALUE_AWS_ELASTIC_BEANSTALK,
} from '@opentelemetry/semantic-conventions/incubating';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't review this soon enough. We decided not to use incubating directly in runtime code.
https://github.com/open-telemetry/opentelemetry-js/tree/main/semantic-conventions#unstable-semconv

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this to my attention. I've opened a new PR to address the issue: #2668

@trentm trentm mentioned this pull request Jan 17, 2025
1 task
@garysassano garysassano deleted the fix-deprecated-aws branch February 15, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants