-
Notifications
You must be signed in to change notification settings - Fork 619
fix(detector-aws): remove all deprecation warnings #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
320fefe
7b60056
dd7aa29
693a09e
cb6a45d
107efcc
91ce6be
7d08d73
4e9dcbd
444254c
29e169c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,15 +25,15 @@ import { | |
| ResourceDetectionConfig, | ||
| } from '@opentelemetry/resources'; | ||
| import { | ||
| SEMRESATTRS_CLOUD_PROVIDER, | ||
| SEMRESATTRS_CLOUD_PLATFORM, | ||
| SEMRESATTRS_SERVICE_NAME, | ||
| SEMRESATTRS_SERVICE_NAMESPACE, | ||
| SEMRESATTRS_SERVICE_VERSION, | ||
| SEMRESATTRS_SERVICE_INSTANCE_ID, | ||
| CLOUDPROVIDERVALUES_AWS, | ||
| CLOUDPLATFORMVALUES_AWS_ELASTIC_BEANSTALK, | ||
| } from '@opentelemetry/semantic-conventions'; | ||
| ATTR_CLOUD_PROVIDER, | ||
| ATTR_CLOUD_PLATFORM, | ||
| ATTR_SERVICE_NAME, | ||
| ATTR_SERVICE_NAMESPACE, | ||
| ATTR_SERVICE_VERSION, | ||
| ATTR_SERVICE_INSTANCE_ID, | ||
| CLOUD_PROVIDER_VALUE_AWS, | ||
| CLOUD_PLATFORM_VALUE_AWS_ELASTIC_BEANSTALK, | ||
| } from '@opentelemetry/semantic-conventions/incubating'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry I didn't review this soon enough. We decided not to use incubating directly in runtime code.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for bringing this to my attention. I've opened a new PR to address the issue: #2668 |
||
| import * as fs from 'fs'; | ||
| import * as util from 'util'; | ||
|
|
||
|
|
@@ -95,12 +95,12 @@ export class AwsBeanstalkDetectorSync implements DetectorSync { | |
| const parsedData = JSON.parse(rawData); | ||
|
|
||
| return { | ||
| [SEMRESATTRS_CLOUD_PROVIDER]: CLOUDPROVIDERVALUES_AWS, | ||
| [SEMRESATTRS_CLOUD_PLATFORM]: CLOUDPLATFORMVALUES_AWS_ELASTIC_BEANSTALK, | ||
| [SEMRESATTRS_SERVICE_NAME]: CLOUDPLATFORMVALUES_AWS_ELASTIC_BEANSTALK, | ||
| [SEMRESATTRS_SERVICE_NAMESPACE]: parsedData.environment_name, | ||
| [SEMRESATTRS_SERVICE_VERSION]: parsedData.version_label, | ||
| [SEMRESATTRS_SERVICE_INSTANCE_ID]: parsedData.deployment_id, | ||
| [ATTR_CLOUD_PROVIDER]: CLOUD_PROVIDER_VALUE_AWS, | ||
| [ATTR_CLOUD_PLATFORM]: CLOUD_PLATFORM_VALUE_AWS_ELASTIC_BEANSTALK, | ||
| [ATTR_SERVICE_NAME]: CLOUD_PLATFORM_VALUE_AWS_ELASTIC_BEANSTALK, | ||
| [ATTR_SERVICE_NAMESPACE]: parsedData.environment_name, | ||
| [ATTR_SERVICE_VERSION]: parsedData.version_label, | ||
| [ATTR_SERVICE_INSTANCE_ID]: parsedData.deployment_id, | ||
| }; | ||
| } catch (e: any) { | ||
| diag.debug(`AwsBeanstalkDetectorSync failed: ${e.message}`); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.