refactor: migrate away from deprecated addMetricReader for SDK 2.0
#2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates from the deprecated `addMetricReader` method to the constructor option in preparation for the upcoming SDK 2.0 release. All usages are in tests and example code, there are no user-facing changes. Fixes open-telemetry#2646
github-actions
bot
added
pkg:instrumentation-mongodb
pkg:instrumentation-runtime-node
pkg:instrumentation-undici
pkg-status:unmaintained
64 tasks
Contributor
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
pichlermarc
changed the title
addMetricReader for SDK 2.0addMetricReader for SDK 2.0
pichlermarc
added
has:sponsor
Member
|
I'll sponsor this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 172 172
Lines 8137 8137
Branches 1649 1649
=======================================
Hits 7402 7402
Misses 735 735 |
github-actions
bot
added
the
pkg-status:unmaintained
Contributor
Author
|
@pichlermarc updated the branch from the UI here, let me know if you need a proper rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates from the deprecated
addMetricReadermethod to the constructor option in preparation for the upcoming SDK 2.0 release.This PR migrates all usages in the entire repository instead of per-package, since there aren't that many total occurrences and they are all in tests and example code. There are no user-facing changes, so I also didn't think there's anything useful to say in the CHANGELOG here.
Fixes #2646 (cc @pichlermarc @trentm)