-
Notifications
You must be signed in to change notification settings - Fork 619
test(*): Migrate away from deprecated addSpanProcessor in tests
#2659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
|
@chancancode thanks for working on this :) |
02619c1 to
03dad02
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2659 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 172 172
Lines 8137 8137
Branches 1649 1649
=======================================
Hits 7402 7402
Misses 735 735 |
|
@chancancode the branch is out of date. Once you update it I'll proceed to merge :) |
This migrates from the deprecated `addSpanProcessor` method to the constructor option in preparation for the upcoming SDK 2.0 release. This commit migrates all usages **in tests** for each package, and there are no changes to the runtime code. Ref open-telemetry#2645
03dad02 to
2558288
Compare
|
@david-luna rebased and resolved the conflict! |
addSpanProcessor in testsaddSpanProcessor in tests
This migrates from the deprecated
addSpanProcessormethod to the constructor option in preparation for the upcoming SDK 2.0 release.This commit migrates all usages in tests for each package, and there are no changes to the runtime code. It's a lot of changes, but since it's all in tests, as long as the tests pass, I don't think there is anything risky in here. It probably doesn't need a CHANGELOG entry either.
Ref #2645 (cc @pichlermarc)
Edit from @pichlermarc
BEGIN_COMMIT_OVERRIDE
test: Migrate away from deprecated addSpanProcessor in tests
END_COMMIT_OVERRIDE