Skip to content

Conversation

@chancancode
Copy link
Contributor

@chancancode chancancode commented Jan 17, 2025

This migrates from the deprecated addSpanProcessor method to the constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates all usages in tests for each package, and there are no changes to the runtime code. It's a lot of changes, but since it's all in tests, as long as the tests pass, I don't think there is anything risky in here. It probably doesn't need a CHANGELOG entry either.

Ref #2645 (cc @pichlermarc)

Edit from @pichlermarc

BEGIN_COMMIT_OVERRIDE
test: Migrate away from deprecated addSpanProcessor in tests
END_COMMIT_OVERRIDE

@github-actions
Copy link
Contributor

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

@david-luna
Copy link
Contributor

@chancancode thanks for working on this :)

@pichlermarc pichlermarc added has:sponsor This package or feature has a sponsor that has volunteered to review PRs and respond to questions and removed pkg-status:unmaintained:autoclose-scheduled labels Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (fed82d5) to head (66d1b48).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2659   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         172      172           
  Lines        8137     8137           
  Branches     1649     1649           
=======================================
  Hits         7402     7402           
  Misses        735      735           

@david-luna
Copy link
Contributor

@chancancode the branch is out of date. Once you update it I'll proceed to merge :)

This migrates from the deprecated `addSpanProcessor` method to the
constructor option in preparation for the upcoming SDK 2.0 release.

This commit migrates all usages **in tests** for each package, and
there are no changes to the runtime code.

Ref open-telemetry#2645
@chancancode
Copy link
Contributor Author

@david-luna rebased and resolved the conflict!

@david-luna david-luna merged commit d9e757f into open-telemetry:main Jan 22, 2025
25 checks passed
@dyladan dyladan mentioned this pull request Jan 22, 2025
@pichlermarc pichlermarc changed the title fix(*): Migrate away from deprecated addSpanProcessor in tests test(*): Migrate away from deprecated addSpanProcessor in tests Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.