Skip to content

refactor(test-utils): Migrate away from deprecated addSpanProcessor #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-luna merged 2 commits into from
Jan 22, 2025
Merged

refactor(test-utils): Migrate away from deprecated addSpanProcessor #2660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31dd654
fix(test-utils): Migrate away from deprecated `addSpanProcessor`
chancancode Jan 17, 2025
1c9142f
Merge branch 'main' into fix-2645-test-utils
chancancode Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions packages/opentelemetry-test-utils/src/instrumentations/otel-default-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,23 @@ import {
export const registerInstrumentationTestingProvider = (
config?: NodeTracerConfig
): NodeTracerProvider => {
const otelTestingProvider = new NodeTracerProvider(config);
const spanProcessors = config?.spanProcessors
? [...config.spanProcessors]
: [];

setTestMemoryExporter(new InMemorySpanExporter());
otelTestingProvider.addSpanProcessor(
new SimpleSpanProcessor(getTestMemoryExporter()!)
);

spanProcessors.push(new SimpleSpanProcessor(getTestMemoryExporter()!));

if (process.env.OTEL_EXPORTER_JAEGER_AGENT_HOST) {
otelTestingProvider.addSpanProcessor(
new SimpleSpanProcessor(new JaegerExporter())
);
spanProcessors.push(new SimpleSpanProcessor(new JaegerExporter()));
}

const otelTestingProvider = new NodeTracerProvider({
...config,
spanProcessors,
});

otelTestingProvider.register();
return otelTestingProvider;
};
Loading