refactor(resource-detector-aws): migrate away from getEnv() #2706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We're planning to remove
getEnv()as it does not scale well when everyone has to update@opentelemetry/coreto get their env vars. ForOTEL_*there will be a replacement utility function. For all others, when the package does not need to be browser-compatible (which seems to be the case here) usingprocess.envdirectly should be fine.Refs open-telemetry/opentelemetry-js#5443
Short description of the changes
This PR removes
getEnv()withprocess.env, it does not inline defaults as leaving them out was semantically equivalent. (they used to be empty strings)