-
Notifications
You must be signed in to change notification settings - Fork 619
fix(aws-sdk): use custom client_context prop
#2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-sdk): use custom client_context prop
#2718
Conversation
faf6b56 to
db2b6c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2718 +/- ##
=======================================
Coverage 89.64% 89.64%
=======================================
Files 184 184
Lines 9032 9032
Branches 1852 1852
=======================================
Hits 8097 8097
Misses 935 935
🚀 New features to boost your workflow:
|
db2b6c2 to
824ac56
Compare
|
@blumamir @jj22ee @trivikr Sorry to bother, please let me know if you need anything more on this PR. It is really sad that AWS Documentation is misleading https://docs.aws.amazon.com/lambda/latest/dg/nodejs-context.html |
|
@blumamir @jj22ee @trivikr The AWS documentation is now updated https://docs.aws.amazon.com/lambda/latest/dg/nodejs-context.html Can you please merge and release this PR? |
|
Thanks! You may need to merge with main to get the remaining checks to run. |
|
Also @smoke, did |
It never worked, probably. |
In every other language the respected property is `custom` e.g. - https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/9a7f7125ab3f77c47a46be524f29e150536fba6f/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/LambdaImpl.java#L41
76fd1ae to
85a0a76
Compare
…-inject-into-proper-custom-prop


Which problem is this PR solving?
In every other language the respected property carrying the context is
custome.g.Short description of the changes
Customtocustomproperty that is used as context carrier for AWS Lambda Client Context