Skip to content

Conversation

@smoke
Copy link
Contributor

@smoke smoke commented Feb 16, 2025

Which problem is this PR solving?

In every other language the respected property carrying the context is custom e.g.

Short description of the changes

  • rename Custom to custom property that is used as context carrier for AWS Lambda Client Context

@smoke smoke requested a review from a team as a code owner February 16, 2025 23:49
@smoke smoke force-pushed the fix/opentelemetry-instrumentation-aws-lambda-inject-into-proper-custom-prop branch from faf6b56 to db2b6c2 Compare February 17, 2025 11:54
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (6cce92b) to head (dd61438).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2718   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files         184      184           
  Lines        9032     9032           
  Branches     1852     1852           
=======================================
  Hits         8097     8097           
  Misses        935      935           
Files with missing lines Coverage Δ
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smoke smoke force-pushed the fix/opentelemetry-instrumentation-aws-lambda-inject-into-proper-custom-prop branch from db2b6c2 to 824ac56 Compare February 27, 2025 15:27
@smoke
Copy link
Contributor Author

smoke commented Mar 21, 2025

@blumamir @jj22ee @trivikr Sorry to bother, please let me know if you need anything more on this PR.

It is really sad that AWS Documentation is misleading https://docs.aws.amazon.com/lambda/latest/dg/nodejs-context.html
The documentation is wrong instead of
Custom – Custom values that are set by the client application.
it should be
custom – Custom values that are set by the client application.

I have just filed a feedback form, hopefully to correct it.
image

@smoke
Copy link
Contributor Author

smoke commented May 18, 2025

@blumamir @jj22ee @trivikr The AWS documentation is now updated https://docs.aws.amazon.com/lambda/latest/dg/nodejs-context.html
image

Can you please merge and release this PR?

@jj22ee
Copy link
Contributor

jj22ee commented May 19, 2025

Thanks! You may need to merge with main to get the remaining checks to run.

@jj22ee
Copy link
Contributor

jj22ee commented May 19, 2025

Also @smoke, did injectLambdaPropagationContext never work properly before? If it worked in some capacity, I was wondering if this should be labelled as a breaking change.

@smoke
Copy link
Contributor Author

smoke commented May 19, 2025

Also @smoke, did injectLambdaPropagationContext never work properly before? If it worked in some capacity, I was wondering if this should be labelled as a breaking change.

It never worked, probably.

@smoke smoke force-pushed the fix/opentelemetry-instrumentation-aws-lambda-inject-into-proper-custom-prop branch from 76fd1ae to 85a0a76 Compare May 20, 2025 05:52
@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label May 23, 2025
@pichlermarc pichlermarc merged commit e0858f9 into open-telemetry:main May 26, 2025
23 checks passed
@dyladan dyladan mentioned this pull request May 26, 2025
@smoke smoke deleted the fix/opentelemetry-instrumentation-aws-lambda-inject-into-proper-custom-prop branch June 18, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants