-
Notifications
You must be signed in to change notification settings - Fork 619
ci: Add Github action to add "has:owner-approval" label for approved PRs #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Github action to add "has:owner-approval" label for approved PRs #2798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
==========================================
+ Coverage 89.69% 89.74% +0.04%
==========================================
Files 186 186
Lines 9048 9048
Branches 1855 1855
==========================================
+ Hits 8116 8120 +4
+ Misses 932 928 -4 🚀 New features to boost your workflow:
|
JacksonWeber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
overall looks good, let's use some explicit permissions and then we can get this merged. 🙂 |
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comment
|
Updated, thanks for reviewing @pichlermarc let me know if there is something else |
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah - looks like the script is missing +x permissions.
|
(see this run) |
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comments
|
@pichlermarc I'm not sure if the change is going to work as I cannot kick off the job, we can coordinate if needed to try different things, hopefully the issue is resolved and that is not needed |
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's still something missing on execution of the workflow.
|
@pichlermarc can you kick off the workflow when you had a chance? |
Which problem is this PR solving?
Automate label tagging for owner reviews in PRs
Short description of the changes
Added scripts to parse component_owners.yml, to get existing components and owners by componer
Added script to get details about a PR, looks for all updated files and determine if one of the owner of that file already approved the PR, then add label.
Added workflow to kick off the script when a PR is reviewed and approved.