Skip to content

Conversation

@pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Apr 29, 2025

Which problem is this PR solving?

See #2804, the declare keyword is missing, which is required for our version of TypeScript (yes, this is a footgun in @opentelemetry/instrumentation). I'm not exactly sure why the tests were not failing here.

Fixes #2804

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (f07dcce) to head (f3fad29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   89.55%   89.50%   -0.05%     
==========================================
  Files         180      180              
  Lines        8719     8719              
  Branches     1767     1767              
==========================================
- Hits         7808     7804       -4     
- Misses        911      915       +4     
Files with missing lines Coverage Δ
...ode/instrumentation-kafkajs/src/instrumentation.ts 97.57% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Apr 29, 2025
@pichlermarc pichlermarc merged commit 32f41ee into open-telemetry:main Apr 29, 2025
23 checks passed
@pichlermarc pichlermarc deleted the fix/kafkajs-metrics branch April 29, 2025 14:37
@dyladan dyladan mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

instrumentation-kafkajs - _clientDuration undefined error during instrumentation

3 participants